Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include a mapping for yOffset for different blocks (and entities?) #132

Open
SpraxDev opened this issue Mar 8, 2022 · 1 comment
Open

Include a mapping for yOffset for different blocks (and entities?) #132

SpraxDev opened this issue Mar 8, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@SpraxDev
Copy link
Owner

SpraxDev commented Mar 8, 2022

Currently, the default yOffset is dependent on (ChairUtils:114):

  • Sitting on ArmorStand?
  • Sitting on TrapDoor?
  • Sitting on Stair/Slab?

This could be extended for all types of blocks. Most are perfect cubes (1x1x1) and do not require any special treatment.

If anybody wants to do the research for the offsets, that would be really appreciated! (#130)
@SpraxDev SpraxDev added enhancement New feature or request help wanted Extra attention is needed labels Mar 8, 2022
@SpraxDev SpraxDev changed the title Include a big mapping for yOffset for different blocks (and entities?) Include a mapping for yOffset for different blocks (and entities?) Mar 8, 2022
@SpraxDev
Copy link
Owner Author

This also seems to be version dependent ,_,
Stairs for example need another offset in 1.20+ although they look the same height? Maybe it's related to the ArmorStand?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SpraxDev