Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure BE/CN added into blocklist for at least X seconds before removal #54111

Open
kevincai opened this issue Dec 19, 2024 · 0 comments · May be fixed by #54203
Open

Ensure BE/CN added into blocklist for at least X seconds before removal #54111

kevincai opened this issue Dec 19, 2024 · 0 comments · May be fixed by #54203
Assignees
@kevincai
Labels
type/enhancement Make an enhancement to StarRocks

Comments

@kevincai
Copy link
Contributor

kevincai commented Dec 19, 2024 •
edited
Loading

Enhancement

When there are some errors to the BE/CN, the node will be added to the blocklist for a while. There is a backend thread to refresh the blocklist and remove the node if meets certain criteria.

It is possible that the node is just added into the blocklist and then is removed from the blocklist immediately by the backend refresh thread.

Proposal

Have a minimal time for a node in staying in the blocklist.
@kevincai kevincai added the type/enhancement Make an enhancement to StarRocks label Dec 19, 2024
@kevincai kevincai self-assigned this Dec 19, 2024
kevincai added a commit to kevincai/starrocks that referenced this issue Dec 21, 2024
@kevincai
[Enhancement] add penalty time when node is added in blocklist
ff9d848 
* add penalty time when a node is added into the blocklist to avoid the
  node get removed from the list too quick

Fixes StarRocks#54111

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
@kevincai kevincai linked a pull request Dec 21, 2024 that will close this issue
Open
24 tasks
kevincai added a commit to kevincai/starrocks that referenced this issue Dec 22, 2024
@kevincai
[Enhancement] add penalty time when node is added in blocklist
0d725fc 
* add penalty time when a node is added into the blocklist to avoid the
  node get removed from the list too quick

Fixes StarRocks#54111

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
kevincai added a commit to kevincai/starrocks that referenced this issue Dec 23, 2024
@kevincai
[Enhancement] add penalty time when node is added in blocklist
daafb0c 
* add penalty time when a node is added into the blocklist to avoid the
  node get removed from the list too quick

Fixes StarRocks#54111

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
kevincai added a commit to kevincai/starrocks that referenced this issue Dec 23, 2024
@kevincai
[Enhancement] add penalty time when node is added in blocklist
9b70dad 
* add penalty time when a node is added into the blocklist to avoid the
  node get removed from the list too quick

Fixes StarRocks#54111

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevincai kevincai

Labels
type/enhancement Make an enhancement to StarRocks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Enhancement] add penalty time when node is added in blocklist kevincai/starrocks
1 participant
@kevincai