Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update action Auto create git branch upon new issue to escape branch names with slashes #1426

Closed
chrisjsimpson opened this issue Dec 28, 2024 · 1 comment
Closed

Update action Auto create git branch upon new issue to escape branch names with slashes #1426

chrisjsimpson opened this issue Dec 28, 2024 · 1 comment
Labels
released This issue/pull request has been released.

Comments

@chrisjsimpson
Copy link
Contributor

Is your feature request related to a problem? Please describe.

https://github.com/Subscribie/subscribie/blob/79b37563cca11f1442df72b0ba871ee6753a3b7c/.github/workflows/git-auto-issue-branch-creation.yml

The issue branch name is admin/invoices/failed/ 
fatal: '1425-admin/invoices/failed/' is not a valid branch name
hint: See `man git check-ref-format`
hint: Disable this message with "git config advice.refSyntax false"

Describe the solution you'd like

Use an allow list rather than trying to escape individual chars

Describe alternatives you've considered

Additional context
chrisjsimpson added a commit that referenced this issue Dec 28, 2024
@chrisjsimpson
Fix #1426 ALLOWED_BRANCH_NAME_CHARS in auto issue branch creation
6da0dac
@chrisjsimpson chrisjsimpson mentioned this issue Dec 28, 2024
Merged
@github-actions github-actions bot added the released This issue/pull request has been released. label Dec 28, 2024
@github-actions GitHub Actions
Copy link

🚀 Issue was released in v0.1.217 🚀

@chrisjsimpson chrisjsimpson mentioned this issue Dec 28, 2024
Open
chrisjsimpson added a commit that referenced this issue Dec 28, 2024
@chrisjsimpson
Fix #1426 ALLOWED_BRANCH_NAME_CHARS in auto issue branch creation
fcc2495
@chrisjsimpson chrisjsimpson mentioned this issue Dec 28, 2024
Merged
chrisjsimpson added a commit that referenced this issue Dec 28, 2024
@chrisjsimpson
Fix #1426 ALLOWED_BRANCH_NAME_CHARS in auto issue branch creation
2ba5377
chrisjsimpson added a commit that referenced this issue Dec 28, 2024
@chrisjsimpson
Fix #1426 ALLOWED_BRANCH_NAME_CHARS in auto issue branch creation
150fa8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisjsimpson