As a Subscriber I can see both *failing* and *failed* invoices

[chrisjsimpson]

Is your feature request related to a problem? Please describe.

Currently, as a Subscriber I can only see failed invoices not failing invoices.
See #811

Describe the solution you'd like

As a Subscriber I can see both failing and failed invoices.

Describe alternatives you've considered

Additional context
This is an enhancement to #811

This is blocking #848

[chrisjsimpson]

1. Shop owner side its ok to only show failed payments, but why not treating the failed and failing payments the same for the subscribers. For example, as you say in the video, they might know that the payment will keep failing so they can change it right away.

More detail below

One way that i could thing of is,
Creating another function
like get_stripe_failed_subscription_invoices, maybe get_stripe_failing_subscription_invoices and deleting this line 413 or changing to invoices.next_payment_attempt is not None

Nice! This is sounds like on the right lines, see below some ideas 👍

In code, we need to be able to return at least these two things:

• list of failed invoices: (we already have that, here in get_stripe_failed_subscription_invoices) ✔️

• list of failing invocies: We don't have this in code yet. Crudly , we something like get_stripe_failing_subscription_invoices would surfice. Given get_stripe_failed_subscription_invoices returns a list, it makes sense for get_stripe_failing_subscription_invoices to also return a list , so that, if you wanteded to, that they may be joined togeather [1,2,3] + [4,5,6]

Shop owner side its ok to only show failed invoices

It's not ok to only show failed invoices. Showing failing invoices is also useful to shop owners- It simply was not coded yet. Why? Showing failed invoices is more critical to shop owners, because by this time all automated collection attempts have failed.

This issue (with the above code implemented) will be useful for both subscribers and shop owners. What we do in the UI should be flexibile, so it's important to have the ability to distingish between failed and failing invoices.

For example: A combination (join) of get_stripe_failing_subscription_invoices and get_stripe_failing_subscription_invoices

Invoice ID	Date	Payment attempts	Status
3245	dd/mm/yyyy	5	failed
4763	dd/mm/yyyy	5	failed
36475	dd/mm/yyyy	3	failing
36475	dd/mm/yyyy	1	failing

but why not treating the failed and failing invoices the same for the subscribers

Because it's extreemly useful to know which invoices will be automatically retried (automation, no manual effort needed) vs failed invoices, for which a manual human action must be taken.

e.g.

• As a subscriber, I am busy and forget /ignore the payment notification for the failing invoice (this is OK ✔️ because the invoice is going to be automatically retried anyway)

• As a subscriber, I am busy and forget /ignore the payment notification for the failed invoice (this is not OK 🔴 because the invoice is not going to be automatically retried anymore- this must be paud manually)

• As a shop owner, I'm mostly interested in failed invoices because I know that my subscribers are alerted when a charge fails- things are more serious only when invoices are failed, although I still like to be aware of failing invoices, they are less critical.