Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc-build action should complain loudly #133

Closed
kbarros opened this issue Aug 21, 2023 · 1 comment
Closed

Doc-build action should complain loudly #133

kbarros opened this issue Aug 21, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@kbarros
Copy link
Member

kbarros commented Aug 21, 2023

If the Github actions for doc-building fails to execute a cell, it will write a warning to the log and happily continue. Instead, it would be better to send out email notifications that Sunny is failing. Perhaps fixing this is as simple as finding the right option in Documenter.jl?
@kbarros kbarros added the good first issue Good for newcomers label Aug 21, 2023
@kbarros
Copy link
Member Author

kbarros commented Sep 19, 2023

I think it's fixed now with the move to Documenter 1.0, where strict=true has become the default. (The keyword has been removed because it's always on.)

@kbarros kbarros closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kbarros