Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing the navbar whenever a link is clicked in navbar in mobile view. #583

Closed
rohinish404 opened this issue Jan 22, 2023 · 7 comments · Fixed by #637
Closed

Closing the navbar whenever a link is clicked in navbar in mobile view. #583

rohinish404 opened this issue Jan 22, 2023 · 7 comments · Fixed by #637
Labels
assigned bug Something isn't working

Comments

@rohinish404
Copy link

Description

Whenever a link to new section is clicked in the navbar in mobile view, the navbar stays in that place itself and the user has to close the navbar everytime they move to different section. So i think it should get closed by itself after reaching the section. It will help in improving user experience.

Screen.Recording.2023-01-22.at.11.11.57.PM.mov

Screenshots

No response

Additional information

No response

@rohinish404 rohinish404 added the bug Something isn't working label Jan 22, 2023
@chs-mix
Copy link

chs-mix commented Jan 22, 2023

Could I please work on this?

@rohinish404
Copy link
Author

@chs-mix If the maintainer approves this issue, you can ask them to assign it to you.

@gopaal24
Copy link

@Susmita-Dey @rohinish404 is the issue still open? If yes, can i contribute to it?
Thank you in advance.

@rohinish404
Copy link
Author

@Susmita-Dey @rohinish404 is the issue still open? If yes, can i contribute to it? Thank you in advance.

Yeah you can take up this issue! Just look around in the website that is this issue still relevant or not.

@gopaal24
Copy link

@rohinish404 the issue still seems unsolved. So, should i wait for @Susmita-Dey to assign it to me or can i go ahead and open a PR once it is done?

@rohinish404 rohinish404 removed their assignment Nov 27, 2023
@rohinish404
Copy link
Author

@rohinish404 the issue still seems unsolved. So, should i wait for @Susmita-Dey to assign it to me or can i go ahead and open a PR once it is done?

I've unassigned myself. You can wait to get assigned but if in 2 3 days you don't get any response just make a pr and mention this issue in that! All the best :)

@sourabh32
Copy link
Contributor

sourabh32 commented Dec 5, 2023

Fixed this issue #[637]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants