Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageView not sliding down when using tableView inside it. #473

Open
nobin97 opened this issue Jun 14, 2021 · 3 comments
Open

MessageView not sliding down when using tableView inside it. #473

nobin97 opened this issue Jun 14, 2021 · 3 comments

Comments

@nobin97
Copy link

nobin97 commented Jun 14, 2021

Hi there, Thanks for this great library.
I'm facing an issue where I have a xib with a tableview in it, pinned to all sides. And I'm changing the tableview height using content size. so the message views size can vary. Now when the tableview content size is too big the scrolling comes in. Everything works except when I try to scroll down in the tableview(after reaching the top cell), the message view doesn't scroll with it.

Here's the config:

config.presentationStyle = .bottom
config.duration = .forever
config.interactiveHide = true
config.shouldAutorotate = false
config.presentationContext = .window(windowLevel: .normal)
config.dimMode = .color(color: AppColors.black.withAlphaComponent(0.8), interactive: true)

Is this a issue with the library? Or am I missing something? Please advice.

@wtmoose
Copy link
Member

wtmoose commented Jun 14, 2021

I'm not fully understanding the problem. Can you post a screen recording?

@nobin97
Copy link
Author

nobin97 commented Jun 15, 2021

Screen.Recording.2021-06-15.at.10.00.29.AM.mov

So, as you can see I can't dismiss the message view when scrolling down in the tableView. it is working when there is no scrolling in the tableView.

@wtmoose
Copy link
Member

wtmoose commented Jun 15, 2021

That wouldn't just work.

The behavior you're expecting would require coordination between your table view's gesture recognizers (which SwiftMessages has no idea about) and the gesture recognizer used to dismiss the message.

I'm flagging this as a feature request. I'll look into it if I can find some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@wtmoose @nobin97 and others