Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto: enable import/no-cycle eslint check #1431

Open
n0izn0iz opened this issue Nov 30, 2024 · 0 comments
Open

refacto: enable import/no-cycle eslint check #1431

n0izn0iz opened this issue Nov 30, 2024 · 0 comments

Comments

@n0izn0iz
Copy link
Collaborator

n0izn0iz commented Nov 30, 2024

import cycles can create subtle and hard-to-debug problems
we should add "import/no-cycle": "error" to the eslint config
current errors:

/Users/norman/Code/teritori-dapp/packages/components/TopMenu/TopMenu.tsx
  4:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/components/TopMenu/TopMenuBox.tsx
  10:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/components/multisig/MultisigTransactionActions.tsx
  4:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/components/multisig/MultisigTransactionItem.tsx
  5:1  error  Dependency cycle detected  import/no-cycle
  6:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/components/multisig/MultisigTransactionModal.tsx
  4:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/components/navigation/components/SidebarButton.tsx
  10:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/components/navigation/components/SidebarNestedButton.tsx
  8:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/components/socialFeed/RichText/inline-toolbar/lib/components/Toolbar/index.d.ts
  5:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/components/socialFeed/RichText/inline-toolbar/lib/index.d.ts
  7:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/Mini/ConnectLedger/ConnectLedgerScreen.tsx
  5:1  error  Dependency cycle detected  import/no-cycle
  6:1  error  Dependency cycle detected  import/no-cycle
  7:1  error  Dependency cycle detected  import/no-cycle
  8:1  error  Dependency cycle detected  import/no-cycle
  9:1  error  Dependency cycle detected  import/no-cycle
  10:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/Mini/ConnectLedger/components/ConnectDevice.tsx
  5:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/Mini/ConnectLedger/components/CreatePassword.tsx
  6:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/Mini/ConnectLedger/components/LoadingAccounts.tsx
  5:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/Mini/ConnectLedger/components/OpenHelpInApp.tsx
  5:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/Mini/ConnectLedger/components/RequestingPermission.tsx
  5:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/Mini/ConnectLedger/components/SelectAccounts.tsx
  6:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/Projects/defaultValues.ts
  1:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/Projects/hooks/useMakeRequestHook.tsx
  6:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/UserPublicProfile/UserPublicProfileScreen.tsx
  4:1  error  Dependency cycle detected  import/no-cycle
  5:1  error  Dependency cycle detected  import/no-cycle
  6:1  error  Dependency cycle detected  import/no-cycle
  7:1  error  Dependency cycle detected  import/no-cycle
  8:1  error  Dependency cycle detected  import/no-cycle
  9:1  error  Dependency cycle detected  import/no-cycle
  10:1  error  Dependency cycle detected  import/no-cycle
  11:1  error  Dependency cycle detected  import/no-cycle
  12:1  error  Dependency cycle detected  import/no-cycle
  13:1  error  Dependency cycle detected  import/no-cycle
  14:1  error  Dependency cycle detected  import/no-cycle
  15:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/UserPublicProfile/tabScreens/DAOsUPPScreen.tsx
  3:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/UserPublicProfile/tabScreens/FundsUPPScreen.tsx
  4:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/UserPublicProfile/tabScreens/GnoDemoUPPScreen.tsx
  3:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/UserPublicProfile/tabScreens/MembersUPPScreen.tsx
  3:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/UserPublicProfile/tabScreens/MentionsPostsUPPScreen.tsx
  4:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/UserPublicProfile/tabScreens/MusicUPPScreen.tsx
  4:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/UserPublicProfile/tabScreens/NFTsUPPScreen.tsx
  3:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/UserPublicProfile/tabScreens/PostsUPPScreen.tsx
  4:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/UserPublicProfile/tabScreens/PremiumContentScreen.tsx
  7:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/UserPublicProfile/tabScreens/ProposalsUPPScreen.tsx
  3:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/UserPublicProfile/tabScreens/QuestsUPPScreen.tsx
  3:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/screens/UserPublicProfile/tabScreens/VideosUPPScreen.tsx
  4:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/store/slices/dapps-store.ts
  3:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/store/slices/marketplaceCartItems.ts
  9:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/store/slices/marketplaceFilters.ts
  11:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/store/slices/message.ts
  21:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/store/slices/notification.ts
  8:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/store/slices/search.ts
  3:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/store/slices/settings.ts
  12:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/store/slices/squadPresets.ts
  4:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/store/slices/wallets.ts
  8:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/store/store.ts
  6:1  error  Dependency cycle detected  import/no-cycle
  7:1  error  Dependency cycle detected  import/no-cycle
  11:1  error  Dependency cycle detected  import/no-cycle
  15:1  error  Dependency cycle detected  import/no-cycle
  16:1  error  Dependency cycle detected  import/no-cycle
  17:1  error  Dependency cycle detected  import/no-cycle
  18:1  error  Dependency cycle detected  import/no-cycle
  23:1  error  Dependency cycle detected  import/no-cycle
  24:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/weshnet/client.ts
  9:1  error  Dependency cycle detected  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/weshnet/message/subscriber.ts
  10:1  error  Dependency cycle via ./services:9  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/weshnet/metadata/processEvent.ts
  17:1  error  Dependency cycle via ./services:9=>./metadata/subscriber:19  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/weshnet/metadata/subscriber.ts
  3:1  error  Dependency cycle via ../client:17=>./services:9  import/no-cycle
  /Users/norman/Code/teritori-dapp/packages/weshnet/services.ts
  9:1  error  Dependency cycle detected  import/no-cycle
  ✖ 71 problems (71 errors, 0 warnings)
@n0izn0iz n0izn0iz changed the title refacto: enable import/no-cycle eslint error refacto: enable import/no-cycle eslint check Nov 30, 2024
@n0izn0iz n0izn0iz mentioned this issue Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant