Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only generate stales for deployed services #614

Closed
wants to merge 2 commits into from

Conversation

SteBaum
Copy link
Contributor

@SteBaum SteBaum commented Jul 18, 2024

Which issue(s) this PR fixes

Fixes #613

Additional comments

With this PR stales are only generated for services/components which previously exist in the database.

Agreements

@SteBaum SteBaum self-assigned this Jul 18, 2024
@SteBaum SteBaum force-pushed the stephan/fix/generate-stales branch from 1e3e8fa to 45c8f83 Compare July 26, 2024 08:22
@SteBaum SteBaum requested review from rpignolet and PaulFarault July 26, 2024 08:22
@SteBaum
Copy link
Contributor Author

SteBaum commented Jul 26, 2024

With last force push moved generate_stale_sch_logs function to DAO.

@SteBaum SteBaum force-pushed the stephan/fix/generate-stales branch from 45c8f83 to e415615 Compare July 31, 2024 10:22
@SteBaum
Copy link
Contributor Author

SteBaum commented Jul 31, 2024

With last force push separated into two commits for easier understanding.

@PaulFarault
Copy link
Contributor

With last force push moved generate_stale_sch_logs function to DAO.

Why?

@PaulFarault PaulFarault closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate stales only for existing services
2 participants