Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can probably mess with the DI node #57

Open
Tamschi opened this issue Sep 6, 2021 · 0 comments
Open

Users can probably mess with the DI node #57

Tamschi opened this issue Sep 6, 2021 · 0 comments
Labels
good first issue Good for newcomers type: bug Something isn't working as expected
Milestone

Comments

@Tamschi
Copy link
Owner

Tamschi commented Sep 6, 2021

I'm pretty sure template users can currently replace the implicit node instance used in the constructor for dependency-injection, as it only has call-site resolution.

Instead, it should be layered like the this context inside the render method, with the call-site-visible node being only a reference to the original node that's grabbed for example by subexpression constructor deference through defer and bind.

@Tamschi Tamschi added type: bug Something isn't working as expected good first issue Good for newcomers labels Sep 6, 2021
@Tamschi Tamschi added this to the v1.0.0 milestone Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

1 participant