Добавление ролей пользователя без конечных точек #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksanderNekr
requested changes
Oct 24, 2024
| b.Property<string>("Username") | ||
| .IsRequired() | ||
| .HasMaxLength(255) | ||
| .HasMaxLength(300) |
There was a problem hiding this comment.
Это зря добавилось
backend/WebApi/Database/Migrations/20241023183751_Add property Role to User.cs
Outdated
Show resolved
Hide resolved
| @@ -6,7 +6,7 @@ public class User | |||
| { | |||
| public int Id { get; init; } | |||
|
|
|||
| [MaxLength(255)] | |||
| [MaxLength(300)] | |||
There was a problem hiding this comment.
Тоже зря закоммитил это
There was a problem hiding this comment.
Нужно вернуть на 255
AleksanderNekr
requested changes
Oct 24, 2024
| @@ -9,6 +9,7 @@ | |||
| using Microsoft.AspNetCore.Identity; | |||
| using Microsoft.AspNetCore.Mvc; | |||
| using Microsoft.EntityFrameworkCore; | |||
| using Microsoft.EntityFrameworkCore.Metadata; | |||
namaksimow
force-pushed
the
feature/roles
branch
from
f16efce to
fa07d41
Compare
AleksanderNekr
requested changes
Oct 25, 2024
| @@ -126,6 +130,7 @@ | |||
| Username = registration.Username, | |||
| UsernameNormalized = usernameNormalized, | |||
| PasswordHash = registration.Password, | |||
| Role = (Role)Enum.Parse(typeof(Role), registration.Role.ToString()), | |||
There was a problem hiding this comment.
Переводить в строку, чтоб потом из строки обратно?)
Можно же просто Role = registration.Role,
Comment on lines
+86
to
+87
| builder.Services.AddAuthorizationBuilder().AddPolicy("admin_greetings", policy => | ||
| policy.RequireRole(Role.Admin.ToString())); |
There was a problem hiding this comment.
Так лучше
builder.Services.AddAuthorizationBuilder()
.AddPolicy(Role.Admin.ToString(), policy => policy.RequireRole(Role.Admin.ToString()));
| }); | ||
| }) | ||
| .RequireAuthorization(); | ||
|
|
||
| app.MapGet("/ping", () => "pong") | ||
| .WithTags("Health"); | ||
|
|
||
| app.MapGet( | ||
| "/role", |
| Items = Enum.GetValues<Role>(), | ||
| })); | ||
|
|
||
| app.MapGet("/admin", () => "admin is you").RequireAuthorization("admin_greetings"); |
There was a problem hiding this comment.
app.MapGet("/admin", () => "admin is you")
.RequireAuthorization(Role.Admin.ToString());
There was a problem hiding this comment.
Рекомендация: если методы с длинными названиями, то лучше переносить их вызовы на новую строку
| public sealed record RegisterRequest([property: EmailAddress] string Email, string Username, string Password, Enum Role); |
There was a problem hiding this comment.
Вместо Enum → Role
| @@ -6,7 +6,7 @@ public class User | |||
| { | |||
| public int Id { get; init; } | |||
|
|
|||
| [MaxLength(255)] | |||
| [MaxLength(300)] | |||
There was a problem hiding this comment.
Нужно вернуть на 255
AleksanderNekr
requested changes
Oct 25, 2024
| @@ -82,6 +83,9 @@ | |||
| }); | |||
| builder.Services.AddAuthorization(); | |||
|
|
|||
| builder.Services.AddAuthorizationBuilder().AddPolicy("admin_greetings", policy => | |||
| policy.RequireRole(Role.Admin.ToString())); | |||
|
|
|||
| var app = builder.Build(); | |||
|
|
|||
There was a problem hiding this comment.
В эндпоинтах входа и регистрации в клеймы добавь
new(ClaimTypes.Role, user.Role.ToString()),
AleksanderNekr
added
cifra-feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.