Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] support search URLs #2313

Open
2 of 3 tasks
ildar opened this issue Apr 30, 2019 · 5 comments
Open
2 of 3 tasks

[FR] support search URLs #2313

ildar opened this issue Apr 30, 2019 · 5 comments
Assignees
Labels
feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project search Anything related to the search function

Comments

@ildar
Copy link

ildar commented Apr 30, 2019

opening from external apps. Think URL intents should be added and such...

@TobiGr TobiGr added the feature request Issue is related to a feature in the app label May 1, 2019
@Stypox Stypox added the good first issue Easy/simple issues perfect for newcomers to get involved in the project label Sep 29, 2019
@haux205
Copy link

haux205 commented Jan 8, 2020

I would like to work on this issue. I'm new to open source so can someone walk me through the process ?

@Stypox
Copy link
Member

Stypox commented Jan 8, 2020

@haux205 yeah sure, you are welcome :-D

NewPipe uses a library called NewPipeExtractor to handle most service-specific things (such as parsing data). This also includes link handling, so you should change things there. So you probably have to take a look to YouTube's link handlers, or more specifically, the Youtube search query link handler (which currently is only able to generate urls).
Since no service so far ever needed to handle search urls you need to add the check in the function that handles all urls along with adding a new search link type.

Since the urls you will add have the same domain as normal youtube urls, you shouldn't need to change anything in the app's Android manifest. Handle search urls here in the in the MainActivity intent handler.

If you have any more questions or need help with setting up the environment, feel free to ask ;-)

@SydneyDrone
Copy link
Contributor

I'm interested in fixing this issue, but I don't know the PR mentioned above has fixed this problem or not. Another question is that
I'm not sure the idea of fixing this issue is still the same.

@Stypox
Copy link
Member

Stypox commented Apr 30, 2022

@SydneyDrone no, the PR mentioned above was closed. This should be solvable without too many issues, just follow the points in my comment above. Thanks :-)

@Sola0404
Copy link

Hi, I am a computer science student in ANU, and I really hope I could try to fix this issue and create PR for it. Could you please assign me to this issue? Thanks in advance!

@Sola0404 Sola0404 mentioned this issue Oct 26, 2022
5 tasks
@SameenAhnaf SameenAhnaf added the search Anything related to the search function label Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project search Anything related to the search function
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants