-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] support search URLs #2313
Comments
I would like to work on this issue. I'm new to open source so can someone walk me through the process ? |
@haux205 yeah sure, you are welcome :-D NewPipe uses a library called NewPipeExtractor to handle most service-specific things (such as parsing data). This also includes link handling, so you should change things there. So you probably have to take a look to YouTube's link handlers, or more specifically, the Youtube search query link handler (which currently is only able to generate urls). Since the urls you will add have the same domain as normal youtube urls, you shouldn't need to change anything in the app's Android manifest. Handle search urls here in the in the MainActivity intent handler. If you have any more questions or need help with setting up the environment, feel free to ask ;-) |
I'm interested in fixing this issue, but I don't know the PR mentioned above has fixed this problem or not. Another question is that |
@SydneyDrone no, the PR mentioned above was closed. This should be solvable without too many issues, just follow the points in my comment above. Thanks :-) |
Hi, I am a computer science student in ANU, and I really hope I could try to fix this issue and create PR for it. Could you please assign me to this issue? Thanks in advance! |
opening from external apps. Think URL intents should be added and such...
The text was updated successfully, but these errors were encountered: