DdlNodeVisitor Processing Of Teiid Temp Tables Needs To Be Improved

[elvisisking]

ModeShape 4.5 now parses Teiid temp table DDL. New node types/mixins were created as there are different kinds of "create temp table" statements. The following, at a minimum, should be done:

• update DdlNodeVisitor to handle all versions of Teiid temp table DDL,
• remove the @Ignore from TestDdlNodeVisitor.testGlobalTemporaryTable() and make sure this test passes, and
• add additional tests to TestDdlNodeVisitor to ensure complete testing of Teiid temp table DDL.

See #347 and #348 for related information.

[elfilip]

Local temporary tables can't be defined in the VDB's ddl because Teiid doesn't support local temporary tables in the schema level metadata. Import of such ddl should fail.

[elvisisking]

The Teiid DDL sequencer recently was improved to handle all variations of Teiid DDL create temporary table statements so I am a bit confused. @blafond do you agree with @elfilip's statement that the Komodo importer should fail? If so, then it follows that the DdlNodeVisitor would not need to handle the exporting of those types of temporary tables.

[blafond]

I spent some time trying to understand temp tables recently by reading the Teiid docs. The Teiid BNF definition covers BOTH DDL statements targeted at deployable VDB metadata AND for Statements and SQL that can be executed against the runtime. That's where I think Temp tables will be/are used. So "modelling" Temp Table statements for VDB's is probably not applicable. I'd recommend getting shawkins take on this to confirm.

[blafond]

Local Temp Table DDL statements are not support as "model" metadata DDL statements. Whatever we need to do to prevent this... we need to do. From their docs (https://docs.jboss.org/author/display/TEIID/Temp+Tables) it appears that a DDL statement like: CREATE LOCAL TEMPORARY TABLE TEMP (a integer, b integer, c integer); could be embedded in a Virtual Procedure as part of the SQL statement. So at some level, MS and Komodo will need to support that statement, but just not at the "model child" level