Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the APIs out to a dedicated repo #27

Open
myidpt opened this issue Sep 27, 2020 · 1 comment
Open

Move the APIs out to a dedicated repo #27

myidpt opened this issue Sep 27, 2020 · 1 comment

Comments

@myidpt
Copy link

myidpt commented Sep 27, 2020

It would be worthwhile to move the APIs in https://github.com/thalescpl-io/k8s-kms-plugin/tree/master/apis to a dedicated repo, such as https://github.com/thalescpl-io/k8s-kms-plugin-apis. This will greatly remove the dependencies.

For example, the istio/api go.mod file is very short: https://github.com/istio/api/blob/master/go.mod

Currently consumers of k8s-kms-plugin have to import all the dependencies of k8s-kms-plugin, making it hard to manage the go dependency versions. So far we have seen the licensing issues and the golang.org/x/sys version compatibility issue #26.

@hoskeri
Copy link
Contributor

hoskeri commented Sep 28, 2020

SGTM, I want to make sure the build of the plugin binary itself continues to stay hermetic.

So, after the APIs are moved to the other repo, there should be a vendor'd copy of the apis repo at build time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants