Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript: Image Carousel project requires some clarification #29123

Open
2 of 3 tasks
hbar1st opened this issue Nov 24, 2024 · 2 comments
Open
2 of 3 tasks

Javascript: Image Carousel project requires some clarification #29123

hbar1st opened this issue Nov 24, 2024 · 2 comments

Comments

@hbar1st
Copy link

hbar1st commented Nov 24, 2024

Checks

Describe your suggestion

In the section of the JS curriculum which requests the creation of an image carousel here https://www.theodinproject.com/lessons/node-path-javascript-dynamic-user-interface-interactions, the instructions never specifically say which method they would like us to use to achieve this.

For eg. The image carousel can be setup to use internal links to traverse between the images, or another method is to use scrollIntoView to move the images into position or finally a method to use left property values to manually move the slider div can be used. (here are two different implementations I did: Using a combo of direct internal links and scrollIntoView calls, I created this demo https://hbar1st.github.io/demo-poster-slider/, while I changed the code later on in a different branch to use the left property to move the slider here (sorry no demo) https://github.com/hbar1st/demo-poster-slider/tree/position

I think if there is an intention that one method should be favored over another, the step can be clearer about that in its description as it currently doesn't really suggest a specific method or explicitly require one. I personally found the scrollIntoView method to be better than changing the left position (no maths, and code is easier to read plus the overall effect looks like scrolling for free without any use of animation or translation).

Just some thoughts on this exercise which will hopefully lead to either adding a hint to suggest something to the learners or being more specific that any method to move to the images will be acceptable. Thanks!

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-javascript-dynamic-user-interface-interactions

(Optional) Discord Name

No response

(Optional) Additional Comments

No response

@MaoShizhong
Copy link
Contributor

Agree the wording could do with clarification. It seems like it's alluding towards absolute positioning and manipulating left, which is also what's been taught in the previous course, but since it just says "positioning" generally and not something like "positioning" (or something more explicit), it's not clear if it expects a position-based approach or if that's actually just a generic "position the div via whatever method, including scrollIntoView if you happen to know about it".

@wise-king-sullyman
Copy link
Member

I think some clarity would probably be good as well. @TheOdinProject/javascript anyone disagree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants