Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: HashMap exercise needs explicit suggestion to use 16 buckets at start #29162

Open
2 of 3 tasks
hbar1st opened this issue Dec 7, 2024 · 5 comments
Open
2 of 3 tasks
Assignees

Comments

@hbar1st
Copy link

hbar1st commented Dec 7, 2024

Checks

Describe your suggestion

The HashMap exercise does not explicitly state that the initial buckets used should be 16 but the test setup uses 12 pieces of data which happens to be exactly .75 x 16. In order to reconcile the test steps with the earlier instructions, the earlier instructions need to explicitly state "The initial value for capacity should be 16." it can state that right after this part:

Start by creating a HashMap class or factory function. It’s up to you which you want to use. It should have at least two variables for load factor and capacity.

Once we have explicit directions to create an initial set of 16 buckets, the test instructions make sense (while as they stand now, they really really don't. For eg. If I had picked a capacity size of 19, then 12 pieces of data would definitely not have allowed me to reach a .75 load level)

thanks for your attention to the matter.

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/javascript-hashmap

(Optional) Discord Name

No response

(Optional) Additional Comments

No response

@wise-king-sullyman
Copy link
Member

Seems like a good idea to me, thanks!

@wise-king-sullyman
Copy link
Member

@Alfa06N if you leave a comment here I'll assign you since I see you already have a PR related to this issue.

So that you know for the future though we prefer people not put up PRs for existing issues until they are assigned to them.

@Alfa06N
Copy link

Alfa06N commented Dec 11, 2024

Thank you for letting me know! I appreciate the clarification and will make sure to wait for assignment in the future before submitting a PR. Please feel free to assign this issue to me now since I have already submitted the related PR.

@Alfa06N
Copy link

Alfa06N commented Dec 20, 2024

@wise-king-sullyman Hello! I'd like this issue to be assigned to me and my PR to be helpful.

@Alfa06N
Copy link

Alfa06N commented Dec 22, 2024

This is one of my first PRs, should I do anything else before my PR is accepted? Should I change something about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants