Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuvemshop/Tiendanube SDK 2.0.0 #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Nuvemshop/Tiendanube SDK 2.0.0 #6

wants to merge 5 commits into from

Conversation

lombo
Copy link
Member

@lombo lombo commented Feb 5, 2023

We are launching our new PHP SDK.

This is a major release, meaning we are breaking backwards compatibility — you can check the CHANGELOG for details.

Check README for updated usage examples.

Closes #5.
Closes #4.
Closes #2.

@lombo lombo requested a review from fonse February 5, 2023 21:32

$client = new Http('dummy_store_id');
$response = self::requestAccessToken($client, $post);
if ($response->getStatusCode() !== 200) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Podemos levar 200 a uma constante

src/Auth/OAuth.php Outdated Show resolved Hide resolved
src/Auth/Scopes.php Outdated Show resolved Hide resolved
src/Auth/Scopes.php Outdated Show resolved Hide resolved

private static $requestTelemetry;

public function __construct(string $storeId)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$storeId não teria que ser number?

@lombo lombo requested a review from jotadepaula February 8, 2023 15:18
Ignore cobertura report and composer.phar
Adds a few more Session tests having or not having Scopes
@roberto0arruda
Copy link

Saudações ✋,
Temos alguma previsão para esta PR?

@alebedev80
Copy link

When PR will be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error call \Requests PSR-0 Keep working! Requests out of memory
5 participants