Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScalerModule masks Scaler transform #31

Open
LucaButera opened this issue Nov 14, 2023 · 1 comment
Open

ScalerModule masks Scaler transform #31

LucaButera opened this issue Nov 14, 2023 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@LucaButera
Copy link
Contributor

The issue:
The current ScalerModule implementation inherits the bias and scale parameter from the given Scaler and then uses its own transform implementation. This is not transparent to the user, as, even if one overrides the base implementation of Scaler.transform, the ScalerModule will resort to its own way of scaling the input.
This may lead to unexpected results; in particular considering that the SpatioTemporalDataset wraps every given Scaler into a ScalerModule.

Proposed Solution:
The ScalerModule should inherit also the way in which the original Scaler implements the transform.

@marshka
Copy link
Member

marshka commented Apr 25, 2024

Hi Luca, you're right. The ScalerModule must be a transparent and clear translation of a Scaler for working with torch tensors. I'll put this in the roadmap.

If you already implemented a smart way to do it, feel free to contribute with a PR!

@marshka marshka added bug Something isn't working help wanted Extra attention is needed labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants