Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question Regarding Cosine Limit in renderer.py #137

Open
johanna0626 opened this issue Feb 22, 2024 · 1 comment
Open

Question Regarding Cosine Limit in renderer.py #137

johanna0626 opened this issue Feb 22, 2024 · 1 comment

Comments

@johanna0626
Copy link

Hi,
Thank you for your excellent work. I have been utilizing it in my projects, particularly in computing sine and cosine values. However, in this line
you've set the limit for the cosine value to (-1000, 0). I'm curious about the rationale behind this decision, as typically, the range for cosine values is (-1, 1). If the cosine value falls below -1, it becomes mathematically invalid to compute the corresponding sine value.

Could you kindly shed some light on why the limit was set to (-1000, 0) instead of the standard (-1, 1)? Understanding this would greatly aid my comprehension and usage of your work.

Thank you very much for your time and consideration.

@sshiningg
Copy link

I have the same question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants