Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question Regarding a GitHub Actions Warning Message #42

Closed
zgarciaj opened this issue Jan 22, 2024 · 2 comments
Closed

Question Regarding a GitHub Actions Warning Message #42

zgarciaj opened this issue Jan 22, 2024 · 2 comments
Assignees
Labels
question Further information is requested
Milestone

Comments

@zgarciaj
Copy link
Collaborator

Optional: I believe we can update toml file to avoid message "CoverageWarning: Module trial was never imported. (module-not-imported)"

e.g.,
[tool.coverage.run]
branch = true
source = [ "autopredictor", ]

Attributions:
Config section of pytest-dev/pytest-cov#596
https://github.com/t-pohl/pytest-coverage-err/blob/main/pyproject.toml
https://stackoverflow.com/questions/76442204/configure-pyproject-toml-for-unittest-and-coverage

I'm not entirely certain about the accuracy of this, so further looking into might be necessary. However, should the PR for the update in test_fit.py get approved, the Test section in GitHub Actions does offer verification:
Screenshot 2024-01-22 at 10 22 39 AM
The warning message is still there but does not seem to halt the flow:
Screenshot 2024-01-22 at 10 26 45 AM

That's why considering this as optional -- I'm keen to know your perspective on this!

@s-voon
Copy link
Collaborator

s-voon commented Jan 24, 2024

Hi Zeily, Thanks for looking into this issue! I think that it's also because we don't have the sphinx dependency yet too. I personally think that if we are not rushing to fix this issue, I would rather we fix the warning message too in one go.

@zgarciaj zgarciaj self-assigned this Jan 27, 2024
@zgarciaj zgarciaj added the question Further information is requested label Jan 27, 2024
@zgarciaj zgarciaj added this to the Milestone 3 milestone Jan 27, 2024
@zgarciaj
Copy link
Collaborator Author

You are absolutely right! Thank you for the insight @s-voon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants