Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Increase flexibility of xmake target settings for mod authors. #525

Open
bitonality opened this issue May 24, 2024 · 0 comments · May be fixed by #530
Open

[Improvement] Increase flexibility of xmake target settings for mod authors. #525

bitonality opened this issue May 24, 2024 · 0 comments · May be fixed by #530

Comments

@bitonality
Copy link
Contributor

Streamline and document the process of when mod authors want to deviate from the default ue4ss.mod options.

Current def:

-- This rule is meant to be used by mod targets.
-- Logic that should ONLY apply to mods should be defined in this rule.
-- All other common logic is inherited from the ue4ss.base rule.
-- Example:
-- target("ExampleMod")
--   add_rules("ue4ss.mod")
--   add_includeirs(".")
--   add_files("dllmain.cpp")
rule("ue4ss.mod")
    add_deps("ue4ss.base", {order = true})
    after_load(function(target)
        target:set("kind", "shared")
        target:set("languages", "cxx20")
        target:set("exceptions", "cxx")
        target:add("deps", "UE4SS")
        target:set("group", "mods")
    end)

    on_install(function(target)
        import("mods.install").install(target)
    end)

I need to document how mod authors can alter these settings and save their own custom rules if they want. I'm envisioning allowing users to create an extension of ue4ss.mod like ue4ss.mod.cxx_latest or ue4ss.mod.custom_runtime etc. They'll then be able to use their custom rules in any mods in their UE4SS mono-repo.

@bitonality bitonality linked a pull request May 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant