WIP: ISSUE-215 Elasticsearch for Sparkler - Maven Profiles #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewismc
changed the title
lewismc
requested changes
Mar 10, 2021
There was a problem hiding this comment.
Looking good. Each profile should only copy over the required resources it needs. A different way of saying this is that each profile should exclude any configuration that it doesn't need at runtime. You can take inspiration from https://stackoverflow.com/a/5663653
|
@KilometersFan please update this PR. Thank you |
added 2 commits
March 21, 2021 12:27
…ersion property instead of hard coding the version in the pom
|
Let's hold off on merging this PR. We are still working on design of storage modules and need to make sure that work is solid before we progress further with the Maven build. |
|
Closing down as we no longer use maven. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Changes to sparkler-app pom.xml:
Is this related to an already existing issue on sparkler?
Related to #215
Will it close an existing issue?
Closes #215.
How was this patch tested?
This was tested by building the project running
mvn clean compile package -P solrandmvn clean compile package -P elasticsearchin the sparkler-app directory and running test crawls