-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMRF latest version #68
Comments
Is it time to think about a 'stable' SMRF API that libraries can integrate against, where SMRF is a dependency? Feels like there were a couple of occasions recently that 'broke' things in AWSM and a more stable API could help here. |
I think that we are getting close to have SMRF fairly stable again. These latest round of changes will really help with AWSM. Also, the main problem with AWSM is that there is a lot of repeated code from SMRF in AWSM, so a good cleanup of AWSM will help lessen the affects of SMRF changes. For example, the threading in AWSM is copy and pasted from SMRF. Then once we have a better SMRF integration in AWSM, we can pin it to a specific minor version in the requirements, like |
Got it. Agree that there should be little to no code duplication between the two modules. |
Agreed, it's served us well and it's time to finally do some maintenance on it. |
The latest version of SMRF breaks all sorts of things.
The text was updated successfully, but these errors were encountered: