Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Agent update approval #2465

Open
mondalaci opened this issue Dec 18, 2024 · 3 comments
Open

Manual Agent update approval #2465

mondalaci opened this issue Dec 18, 2024 · 3 comments

Comments

@mondalaci
Copy link
Member

When the "Automatically check for update on application start" settings option is enabled, Agent auto-updates itself without the user's approval, which may be undesirable.

The above option should make a top notification bar appear featuring: "A new Agent update is available. [Review changelog] [Update]"

The "Review changelog" link should go to a new page featuring the Agent and firmware changelog entries since the current Agent/firmware version. Add an "Update Agent" button at the end of this page.

Rename the "Automatically check for update on application start" settings option to "Check for new Agent version on startup"

Add a new settings option below, "Auto-update Agent when a new version is available". Just like now, don't ask for approval when this option is enabled.

@mondalaci
Copy link
Member Author

@ert78gb I'm not sure what the current behavior is. Can Agent auto-update itself without showing the top notification bar? I assume it can. Which software component is responsible for this? Electron updater? What are the relevant options?

@ert78gb
Copy link
Member

ert78gb commented Dec 18, 2024

Can Agent auto-update itself without showing the top notification bar?

We can implement this feature. But for the update needed an Agent restart. That means when the user closes the app and reopens then will run the update.

Or do you mean. the panel was not visible for the user and Agent "accidentally" upgraded itself? It is possible. Agent show only 1 top notification panel at a time. It has a preference order

  1. firmware upgrade
  2. dongle pairing
  3. update available

So it is possible the update available panel is not visible after the update downloaded.
The other idea is/was show multiple notification panel. But it opens other UX question what is the panels that we would like to show at once . We can't show unlimited because we don't have unlimited area. So we could step into the same situation we have more notifications than slots.

Which software component is responsible for this? Electron updater? What are the relevant options?

We use electron-updater

electron-updater has 2 relevant atomic options

  • check for update
  • download update

Agent use the auto update feature as a composite function. Checks for update and if it available it automatically download it. So we could easily implement the "only check update available" functionality.

Just a reminder:
Few years ago we decided we follow the vscode approach (check for update and start immediately download).
Agent shows the update available panel when download finished. In this case the user does not have to wait until the update downloaded.

@abonhote
Copy link

Hi all

The panel was visible, but I didn't click on the update button. Still it got updated.

Downloading the new version in the background is OK, but the installation should at least require some user confirmation.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants