Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve test coverage #5

Open
5 tasks
moodysalem opened this issue Apr 14, 2021 · 0 comments
Open
5 tasks

improve test coverage #5

moodysalem opened this issue Apr 14, 2021 · 0 comments
Labels
p1 Great to have, implement first thing after p0s

Comments

@moodysalem
Copy link
Contributor

moodysalem commented Apr 14, 2021 •
edited by NoahZinsmeister
Loading

p1

  • ApproveAndCall for tokens that require ApprovalType.MAX_MINUS_ONE-style approves
  • PeripheryPaymentsExtended
  • PeripheryPaymentsWithFeeExtended
  • every slippage check
  • fee-on-transfer token swaps
@NoahZinsmeister NoahZinsmeister transferred this issue from Uniswap/v3-periphery Sep 16, 2021
@NoahZinsmeister NoahZinsmeister changed the title need unit tests for each slippage check improve test coverage Sep 28, 2021
@NoahZinsmeister NoahZinsmeister added the p1 Great to have, implement first thing after p0s label Sep 28, 2021
@NoahZinsmeister NoahZinsmeister added p0 Very important to fix p1 Great to have, implement first thing after p0s and removed p1 Great to have, implement first thing after p0s p0 Very important to fix labels Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p1 Great to have, implement first thing after p0s
Projects
Uniswap Protocols Open Issues
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NoahZinsmeister @moodysalem