Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsh build list --json outputs unparsable JSON #2

Open
SoylentGraham opened this issue Aug 24, 2023 · 10 comments
Open

gsh build list --json outputs unparsable JSON #2

SoylentGraham opened this issue Aug 24, 2023 · 10 comments
Labels
bug Something isn't working

Comments

@SoylentGraham
Copy link

SoylentGraham commented Aug 24, 2023

Using --version 1.0.0

[
  {
    "BuildName": "XXXXXX",
    "BuildId": XXXXX,
    "OsFamily": "LINUX",
    "Updated": "2023-08-23T16:43:44Z",
    "BuildConfigurations": 0,
    "SyncStatus": "PENDING",
    "Ccd": {
      "BucketId": "XXXXXX",,      "ReleaseId": "00000000-0000-0000-0000-000000000000"
    },
    "Container": null,
    "S3": null
  }
]

see
"BucketId": "XXXXXX",, "Re
empty field.

@SoylentGraham
Copy link
Author

SoylentGraham commented Aug 24, 2023

Context; I've created a build (with file-upload as the type) from the command line, not added any versions yet.

@yoan-bernatchez
Copy link
Contributor

yoan-bernatchez commented Aug 24, 2023

Thanks for reporting, we're looking into it 🙂

To help us replicate the problem, please provide the following information:

  • Full command used (excluding sensitive information)
  • Operating System the command was ran on

@yoan-bernatchez yoan-bernatchez added the bug Something isn't working label Aug 24, 2023
@GabrielBelmonteUnity
Copy link

GabrielBelmonteUnity commented Oct 3, 2023

That's weird, we're not doing anything fancy for json serialization...
Just to confirm my understanding, are we saying that the JSON is malformed?

@SoylentGraham
Copy link
Author

Pretty sure after logging in, it was
ugs-macos-x64 gsh build list --json
Tested on macos, don't think I ever ran this command on my server (github runner)

@SoylentGraham
Copy link
Author

That's weird, we're not doing anything fancy for json serialization... Just to confirm my understanding, are we saying that the JSON is malformed?

Yeah :)

I use it in here, but I guess I don't use the json coming out now (I still use this action, but haven't touched it since I wrote it & this bug)
https://github.com/condensereality/UnityGameHostingAction

@yoan-bernatchez
Copy link
Contributor

Were you having this problem consistently or did it happen only once?

@SoylentGraham
Copy link
Author

SoylentGraham commented Oct 3, 2023

Were you having this problem consistently or did it happen only once?

  • Every time, on multiple builds
  • manually uploaded builds
  • builds from cli
  • never used buckets

@GabrielBelmonteUnity
Copy link

GabrielBelmonteUnity commented Oct 4, 2023

I asked the GSH team to take a look and they could not repo, but they asked to check what logs come out of this line:
https://github.com/condensereality/UnityGameHostingAction/blob/main/UnityGameServiceClient.js#L70

Out of curiosity, do you have the same behavior when you're not redirecting I/O?
I'm curious if either there's some race-condition going on on either side of the code, either in our I/O or the tools reading of the IO.

@SoylentGraham
Copy link
Author

Had the same output when just used in terminal.

@SoylentGraham
Copy link
Author

If you're curious about the action, check its readme, you can always run it locally & try it yourself, but the exe was the problem.
The c# itself looked fine, but i couldn't build & debug it to try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants