Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider xarray #36

Open
Nitnelav opened this issue Nov 13, 2024 · 3 comments
Open

consider xarray #36

Nitnelav opened this issue Nov 13, 2024 · 3 comments

Comments

@Nitnelav
Copy link
Collaborator

consider xarray for storing multi-channel audio and/or multi-channel spectrograms

@MitchellAcoustics
Copy link
Collaborator

MitchellAcoustics commented Nov 13, 2024

I'm not opposed, it'd make sense. But just thinking about downstream dependencies (yeah, mostly soundscapy) it'd add a new dependency for us. Numpy is used in tons of other packages (pandas, matplotlib, scipy, etc) so it'll always be needed. If acoustic-toolbox switches to xarray, that's a new dependency to resolve and convert to/from. Not a huge issue, but something to keep in mind.

That said, to handle two channel signals and their results in soundscapy I've had to use MultiIndex in Pandas which is a bit of a nightmare, so it might solve stuff!

@MitchellAcoustics
Copy link
Collaborator

Speaking of, if you haven't taken a look, I've already made the scaffolding for one implementation of the acoustics.Signal for multiple channels in soundscapy.Binaural. At some point I was planning to make a PR for porting that up to acoustic-toolbox.

@Nitnelav
Copy link
Collaborator Author

Yes ! I agree that adding a depency must be done carefully. I'm supposed to have a week or two dedicated to acoustic stuff in december. I'll have a look then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants