Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hlsearch Turns On Unexpectedly When Executing Some EasyMotion Shortcuts #9381

Open
yama662607 opened this issue Nov 30, 2024 · 0 comments
Open

Comments

@yama662607
Copy link

yama662607 commented Nov 30, 2024

Describe the bug
When I execute any of the easymotion commands (<leader><leader>s, <leader><leader>f, etc.) after performing a search and hiding the highlights using :nohl, the hlsearch setting is automatically turned back on, causing the search highlights to reappear.
CleanShot 2024-12-07 at 17 00 58

To Reproduce
Steps to reproduce the behavior:

  1. Open a file in VSCode with the Vim extension and easymotion enabled.
  2. Perform a search (e.g., type /search_term and press Enter).
  3. Hide the search highlights by typing :nohl and pressing Enter.
  4. Execute one of the following easymotion commands:
    • <leader><leader>s<char> (Search character)
    • <leader><leader>f<char> (Find character forwards)
    • <leader><leader>F<char> (Find character backwards)
    • <leader><leader>t<char> (Till character forwards)
    • <leader><leader>T<char> (Till character backwards)
  5. Notice that the search highlights reappear automatically.

Expected behavior
The hlsearch setting should remain off after executing easymotion commands, and the search highlights should not reappear unless manually enabled.

Environment

  • Extension (VsCodeVim) version: v1.28.1
  • VSCode version: 1.95.3
  • OS: macOS Sequoia 15.1.1
  • Hardware: MacBook Pro M3 Pro

Additional context
Vim provides various navigation methods, but I believe f, as an advanced version of f, is the fastest and most intuitive way to navigate in Vim. I am eagerly looking forward to its improvement!

@yama662607 yama662607 changed the title hlsearch Turns On Unexpectedly When Executing EasyMotion Shortcuts hlsearch Turns On Unexpectedly When Executing Some EasyMotion Shortcuts Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant