Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Improve how we compute sgn for the class Permutation #38

Closed
VascoSch92 opened this issue May 19, 2024 · 0 comments · Fixed by #104
Closed

[ENHANCEMENT] Improve how we compute sgn for the class Permutation #38

VascoSch92 opened this issue May 19, 2024 · 0 comments · Fixed by #104
Assignees
@VascoSch92
Labels
enhancement Make something existing better
Milestone
Release 0.2.0

Comments

@VascoSch92
Copy link
Owner

For instance, when we want to compute the sign of an Permutation object, we convert it to a CycleDecomposition and then
we compute the sign.

Perhaps is better to compute the sign directly by counting the number of inversions, i.e., using the base definition of sign.

To implement that we need #25 .
@VascoSch92 VascoSch92 added the enhancement Make something existing better label May 19, 2024
@VascoSch92 VascoSch92 added this to the Release 0.2.0 milestone May 19, 2024
@VascoSch92 VascoSch92 self-assigned this Jun 12, 2024
@VascoSch92 VascoSch92 mentioned this issue Jun 13, 2024
Merged
5 tasks
@VascoSch92 VascoSch92 linked a pull request Jun 13, 2024 that will close this issue
[ENHANCEMENT][FEATURE] Improve method sng() and add degree() method #104
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VascoSch92 VascoSch92

Labels
enhancement Make something existing better
Projects
None yet
Milestone
Release 0.2.0
Development

Successfully merging a pull request may close this issue.

[ENHANCEMENT][FEATURE] Improve method sng() and add degree() method VascoSch92/symmetria
1 participant
@VascoSch92