Crash when trying to debug binary using the async API incorrectly

[negasora]

Binary Ninja Ultimate 4.3.6564-dev

from binaryninja import load
from binaryninja.debugger import DebuggerController

with load("/usr/bin/ls") as bv:
    dc = DebuggerController(bv)

    if dc.launch():
        stop_reason = dc.go_and_wait()
        print(f"Stop Reason: {dc.stop_reason_str}")
    else:
        print("Failed to launch the target.")

[xusheng6]

You should use launch_and_wait() to launch the target. launch only requests the operation and does not actually perform it

[negasora]

It sounds like there are two bugs:

1. Document async/sync API and how to use them #675 which will fix the documentation that shows this pattern
2. This bug, where the user should be told the target isn't launched yet, instead of crashing with no feedback

[xusheng6]

Re-opening this -- as mentioned above, even if the user is using the API in a wrong way, we should not crash

[xusheng6]

This is a UAF on the debugger controller and the objects owned by it. I am not sure there is actually a way to fix it.

Hopefully #676 and #675 will make this less likely to happen