Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typos in oauth.json cause silent fallback to oauth.fallback.json #1

Open
ghukill opened this issue Jun 3, 2019 · 0 comments
Open

typos in oauth.json cause silent fallback to oauth.fallback.json #1

ghukill opened this issue Jun 3, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@ghukill
Copy link
Member

ghukill commented Jun 3, 2019

If the JSON is not well formed in config/oauth.json, it silently fails to load and the fallback config config/oauth.fallback.json is used.

Saga should likely not start and/or bubble up the error as opposed to silently falling back.
@ghukill ghukill added the bug Something isn't working label Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ghukill