Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): Add BetterGifSend #2850

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

ryawaa
Copy link
Contributor

@ryawaa ryawaa commented Sep 8, 2024

This PR adds a plugin that provides options regarding the configuration of the GIF picker visibility/send behavior.

These behaviors are: (configurable via plugin options), documentation available at the new readme.

This PR also closes: Vencord/plugin-requests#1122

This plugin also replaces GifPaste. (I asked permission from Vee)

@DokterKaj
Copy link
Contributor

Would it be possible to add the same visibility functionality for the emoji and sticker pickers?

@ryawaa
Copy link
Contributor Author

ryawaa commented Sep 14, 2024

Would it be possible to add the same visibility functionality for the emoji and sticker pickers?

Yes, theoretically you can bring it over to the Sticker/Emoji pickers. Thooo it would probably warrant its own plugin.

@ryawaa
Copy link
Contributor Author

ryawaa commented Sep 21, 2024

Upon checking active PRs (which i shouldve done sooner tbh), I noticed an implementation has been made regarding to the shift functionality of this plugin in #2745.

Since our implementation was more or less the same, just me being more explicit. I've decided to include their dev constant here to give credit.

@iminlikewithyou
Copy link

i wouldn't say that the implementation is really the same - because i gave the user between two default options: Insert the link into the chatbox, or send immediately. then, on top of that, i gave them the option to perform the opposite behavior by holding down shift.

you might think that this is equivalent to providing the user with three options (which you did): Insert the link into the chatbox, send immediately, or insert link if shift is held, but it isn't. with your implementation, you can't have inserting the link be the default behavior BUT hold shift to instantly send, because it isn't an option. (this is the option i like to use)

i do really like the new closing behavior here, but i think you should do something more similar to what i did, where you present two options (Close immediately, Keep open) (Insert link, Immediately send), and provide them with an option to use the alternate behavior (a shift override) in order to perform the other action instead. or you could go nuclear and present the user with four options, but imo i think that's less understandable than choosing your defaults and then selecting what you want shift to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep GIF Search Open
3 participants