Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: all Mocks should be private #827

Closed
alestiago opened this issue Oct 3, 2023 · 1 comment · Fixed by #838
Closed

refactor: all Mocks should be private #827

alestiago opened this issue Oct 3, 2023 · 1 comment · Fixed by #838
Assignees
@droidbg
Labels
good first issue Good for newcomers refactor A code change that neither fixes a bug nor add a feature

Comments

@alestiago
Copy link
Contributor

alestiago commented Oct 3, 2023 •
edited
Loading

Description

Throughout the codebase there are instances of public Mocks being used in tests.

Private Mocks benefit from:

  • Explicitly tell the reader this is only intended to use in foo_test.dart
  • Make the test file self contained
  • Avoid accidentally importing it in other test files
  • Benefit from analyzer warnings once Mocks are no longer used in the file

Additional Context
@alestiago alestiago added bug Something isn't working as expected refactor A code change that neither fixes a bug nor add a feature good first issue Good for newcomers and removed bug Something isn't working as expected labels Oct 3, 2023
@alestiago alestiago mentioned this issue Oct 3, 2023
Merged
7 tasks
@droidbg
Copy link
Contributor

droidbg commented Oct 4, 2023

@alestiago I like to pick this up

@alestiago alestiago moved this from Needs Triage to Community in VGV Open Source 🦄 🧙🌟 Oct 4, 2023
@droidbg droidbg mentioned this issue Oct 4, 2023
Merged
7 tasks
@alestiago alestiago moved this from Community to In Review in VGV Open Source 🦄 🧙🌟 Oct 4, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in VGV Open Source 🦄 🧙🌟 Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droidbg droidbg

Labels
good first issue Good for newcomers refactor A code change that neither fixes a bug nor add a feature
Projects
VGV Open Source 🦄 🧙🌟
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: make all mock class to private
2 participants
@droidbg @alestiago