Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index access to dynamic properties in the Liquid notification templates #1316

Closed
tatarincev opened this issue Mar 27, 2018 · 1 comment
Closed

Add index access to dynamic properties in the Liquid notification templates #1316

tatarincev opened this issue Mar 27, 2018 · 1 comment

Comments

@tatarincev
Copy link
Contributor

Currently, if any object in notification has dynamic properties you can't use them by this syntax
order.dynamic_properties.property_name or order.dynamic_properties[property_name]

Technical solution:
In this code need to for all IHasDynamicProperties objects do somehow conversation to Dictionary before adding this object to render context.
https://github.com/VirtoCommerce/vc-platform/blob/dev/VirtoCommerce.Platform.Data.Notifications/LiquidNotificationTemplateResolver.cs#L37
@tatarincev tatarincev added this to the Operations milestone Mar 27, 2018
@t13ka t13ka removed this from the Operations milestone Dec 25, 2019
@tatarincev tatarincev mentioned this issue Dec 30, 2019
Open
@tatarincev
Copy link
Contributor Author

Issue moved to VirtoCommerce/vc-module-notification #8 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tatarincev @t13ka