Traverse continues after a failed push

[PawelLipski]

It occurs to me that it's indeed what I observed recently (specifically, vanilla git push failing on non-fast-forward since the branch was present in the remote repo, but not in refs/remotes locally).

I'd say it should NOT continue; the traverse flow should be stopped at any failure.

[PawelLipski]

Yeah, indeed:

[PawelLipski]

Huh it might be hard to circumvent... com.intellij.dvcs.push.PushController#push simply doesn't throw an exception when the push fails ☹️

[mkondratek]

pls take a look at:
git4idea.push.GitPusher#expireExistingErrorsAndWarnings

I think we could provide a similar solution - notification-based, i.e.:

GitPushResultNotification[] existingNotifications =
  NotificationsManager.getNotificationsManager().getNotificationsOfType(GitPushResultNotification.class, myProject);

then filter for NotificationType.ERROR (I am assuming failed push is an error - not a warn), and then assert the specific details of the notification so we are sure that's our failed push. wdyt?

[PawelLipski]

and then assert the specific details of the notification so we are sure that's our failed push. wdyt?

Huh seems pretty hackish and brittle TBH 🤔 to rely on a notification to determine if an error has happened 🐞