Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge scalafix into fix #3400

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Dec 31, 2024

Closes #3327

This merges the scalafix sub-command into fix.

scala-cli fix . --power
# The `fix` sub-command is experimental
# Please bear in mind that non-ideal user experience should be expected.
# If you encounter any bugs or have feedback to share, make sure to reach out to the maintenance team at https://github.com/VirtusLab/scala-cli
# Running built-in rules...
# Writing project.scala
# Removing directives from Smth.scala
# Built-in rules completed.
# Running scalafix rules...
# 
# Starting compilation server
# Compiling project (Scala 3.6.2, JVM (zulu:23))
# [warn] ./Main.scala:2:7
# [warn] unused local definition
# [warn]   val unused = "unused"
# [warn]       ^^^^^^
# Compiled project (Scala 3.6.2, JVM (zulu:23))
# scalafix rules completed.

Former fix functionalities are now referred to in the code as the built-in rules.
Effectively, fix now runes 2 separate sets of rules (both enabled by default): built-in and scalafix.
They can be controlled via the --enable-scalafix and --enable-built-in command line options.

@Gedochao Gedochao force-pushed the feature/scalafix-follow-up-2 branch from e37dd0f to 613b811 Compare December 31, 2024 14:14
@Gedochao Gedochao changed the title [WIP] Merge scalafix into fix Merge scalafix into fix Jan 7, 2025
@Gedochao Gedochao force-pushed the feature/scalafix-follow-up-2 branch from d7ea710 to 9a45a8b Compare January 7, 2025 11:01
@Gedochao Gedochao marked this pull request as ready for review January 7, 2025 11:01
@Gedochao Gedochao requested review from tgodzik and kasiaMarek January 7, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge scalafix sub-command into fix
1 participant