Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bpaf to fix the broken completions #50

Closed
dgudim opened this issue Oct 29, 2023 · 4 comments
Closed

Bump bpaf to fix the broken completions #50

dgudim opened this issue Oct 29, 2023 · 4 comments

Comments

@dgudim
Copy link

dgudim commented Oct 29, 2023

In some cases completions broke for me (albeit, when i was misusing them, but still a bug). Turns out it's a bpaf bug.

Original issue: akinomyoga/ble.sh#368

It was already reported to bpaf, we just need to wait

@VorpalBlade
Copy link
Owner

Is it this bpaf issue that I reported or yet another one? If so, could you link it here so I can keep track of it.

@VorpalBlade
Copy link
Owner

Hm, seems to be a different one: pacak/bpaf#311

I don't use bash so I wouldn't have noticed it. It would be great to have tests of the completion that bpaf outputs somehow, but it seems quite complicated. Especially since executing the binary from tests tend to break when cross compiling.

@pacak
Copy link

pacak commented Oct 30, 2023

0.9.6 is out

VorpalBlade added a commit that referenced this issue Oct 30, 2023
This fixes issue #50.
@VorpalBlade
Copy link
Owner

This will be included 2.2.0 that is being built as of writing this.

Note that the actual completions themself are still broken pending @pacak fixes pacak/bpaf#303 (no pressure). But at least it should just do nothing instead of error out.

Though I haven't tried this with bash, as I'm not set up to test that. I would like to add auto tests for the completion at a future point, probably once the above mentioned issue is solved (would be kind of pointless while it is still broken).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants