Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example-forum newsletter uses inconsistent cookie methods #92

Open
georgezee opened this issue Sep 21, 2018 · 0 comments
Open

Example-forum newsletter uses inconsistent cookie methods #92

georgezee opened this issue Sep 21, 2018 · 0 comments

Comments

@georgezee
Copy link
Contributor

In commit 6e78509, the cookie handling was refactored to use 'universal-cookie'.
See:
cookies-commit

However the function to update the cookie wasn't changed, which seems a simple oversight. It still uses:
Cookie.save('showBanner', 'no');
rather than:
cookies.set('showBanner', 'no');

Note, I haven't tested this (yet), but it seems straightforward. Will raise a PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant