Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow constructor in React components #26

Open
koorchik opened this issue Aug 23, 2017 · 0 comments
Open

Do not allow constructor in React components #26

koorchik opened this issue Aug 23, 2017 · 0 comments

Comments

@koorchik
Copy link
Member

  1. Do not allow constuctor in React Components
  2. Force static propTypes proporty

I am not sure if this rules should be here. Maybe it is better to create a pull request to eslint-plugin-react

Considered bad:

class List extends React.Component {
    constructor(props) {
        super(props);   
    }

    handleClick() {
    
    }
    
    render() {
        <button onClick={this.handleClick} />
    }
}

Considered good:

class List extends React.Component {
    static propTypes = {};
    
    state = {};

    handleClick = () => {
    
    };
    
    render() {
        <button onClick={this.handleClick} />
    }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant