Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert sizes to human-readable units is always on #2024

Open
1 task done
LennardF1989 opened this issue Dec 24, 2024 · 2 comments
Open
1 task done

Convert sizes to human-readable units is always on #2024

LennardF1989 opened this issue Dec 24, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@LennardF1989
Copy link
Contributor

Operating System

Windows

What's the issue you encountered?

The language key to toggle is still there:

"hex.ui.hex_editor.human_readable_units_footer": "Convert sizes to human-readable units",

Is it intentionally always on?

I think the whole area is being reworked where this button was originally was.

That said, I liked where the selection text was originally. It's now in the status bar, which makes it impossible to select and copy the values.

How can the issue be reproduced?

Start ImHex :D

ImHex Version

1.36.0

ImHex Build Type

  • Nightly or built from sources

Installation type

MSI

Additional context?

No response

@LennardF1989 LennardF1989 added the bug Something isn't working label Dec 24, 2024
@WerWolv
Copy link
Owner

WerWolv commented Dec 24, 2024

Hey, you're not the first one that voiced concerns about me moving the selection to the status bar. This change was mainly done because the hex editor footer was extremely cluttered and looked terrible but also because many many other applications have that information in the same place.

CLion:
image

VSCode:
image

HxD:
image

Notepad:
image

None of these are actually selectable. Would it improve things if I made it clickable?
The "Convert sizes to human-readable units" option disappeared because even before it only affected the size of the selection which is now always displayed in both hex and as human readable bytes so there wasn't any need for it anymore. Also I usually don't remove the language strings of things that are removed / changed in case we need them again in the future because the feature comes back in some other way or it's still useful in another context

@LennardF1989
Copy link
Contributor Author

LennardF1989 commented Dec 24, 2024

I like the original position over the statusbar. Whenever I'm reversing file formats, I'm constantly checking selections and offsets and it being in the statusbar feels like a "long distance" from where the action is happening.

This is my usual layout:
image

Being able to "click to copy" could work, but I would like all things to be a separate entity in that case, like HxD is doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants