Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong link on Wiki to the notebook to download the data #5

Open
kuhnen opened this issue Sep 13, 2019 · 2 comments
Open

Wrong link on Wiki to the notebook to download the data #5

kuhnen opened this issue Sep 13, 2019 · 2 comments

Comments

@kuhnen
Copy link

kuhnen commented Sep 13, 2019

The Wiki has the wrong link to the file https://github.com/WillKoehrsen/wikipedia-data-science/blob/master/notebooks/Downloading%20and%20Parsing%20Wikipedia%20Articles.ipynb
the file is on master only the link to redirect the file on the Wiki is not working.

@WillKoehrsen
Copy link
Owner

Thanks for noticing. The Wikimedia dumps are constantly updated to reflect the newest version of Wikipedia. If you could make a PR updating the links, that would be great. It could point to here: https://dumps.wikimedia.org/enwiki/20190901/ for example (although this will eventually go out-of-date as well).

@moinmir
Copy link

moinmir commented Jul 27, 2020

I just noticed another error. While downloading the files, the name, as well as the origin, is wrong. It should be:

data_paths.append(get_file(path, dump_url + file))

instead of data_paths.append(get_file(file, dump_url))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants