Deleted events page #371
Open
Deleted events page #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trymebytes
force-pushed
the
deleted-events-page
branch
from
f06ff54 to
4eafc69
Compare
amieiro
requested changes
Nov 5, 2024
There was a problem hiding this comment.
I have tested it and the look and feel is nice.
Some comments:
- I think we should move the "Edit icon" to a button like the other two ("Restore" and "Delete permanently").
- I think we should have a confirm button in both buttons: something like "Are you sure you want to delete this event", and something similar for the "Restore" button. These actions are important, and the "Delete" is destructive, so I think a confirmation button will improve the UI.
- When I click in the "Restore" button in the "WordCamp Kerala" event, the event is not restored.
|
We could also use icons instead of buttons? For example for restoring:
And delete permanently: |
trymebytes
force-pushed
the
fix-navigation
branch
from
4bdc5a7 to
2c86571
Compare
trymebytes
force-pushed
the
deleted-events-page
branch
from
eee087b to
6f444bf
Compare
|
Updated view |
|
@trymebytes That's a lot of icons now next to the title (I know this is just for admins but still). Can you try some UI variations with putting them in a dedicated column or just right aligning them? Thanks! |
|
Thanks! Visually I like version 1 better, what do you think? |
|
I agree, it's visually appealing and user-experience wise, I also prefer it to version 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #368
Before
After
