Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if the bot was the last person to talk, postpone it's scheduled callout. #1

Open
pironic opened this issue Sep 24, 2014 · 1 comment · Fixed by #6
Open

if the bot was the last person to talk, postpone it's scheduled callout. #1

pironic opened this issue Sep 24, 2014 · 1 comment · Fixed by #6
Labels
enhancement

Comments

@pironic
Copy link
Member

pironic commented Sep 24, 2014

right now if nobody is in the broadcast the last several things said could all be said by the bot. no need for that.
Reanmachine added a commit to Reanmachine/GS-Broadcast-Bot that referenced this issue Sep 25, 2014
@Reanmachine
Fixed Issue WritheM#1:
655f741 
 - Refactored Chat Handling to use a handler pattern, allowing for registration of many
   handlers for chat messages. Some will process all messages, some will process and then
   prevent further execution.
 - Refactored ShoutOut interval timer to use a self-scheduling pattern, this allows us to
   have it re-schedule for a newly updated time.
 - Moved ShoutOut logic into the GU object
 - Updated ShoutOut logic to prevent it from shouting out if the last person to talk was the
   broadcaster and the last time they talked was about the last time the shout out was sent.
Reanmachine added a commit to Reanmachine/GS-Broadcast-Bot that referenced this issue Sep 25, 2014
@Reanmachine
Fixing Typos in relation to the fix for WritheM#1
f0fa217
@Reanmachine Reanmachine mentioned this issue Sep 25, 2014
Merged
pironic added a commit that referenced this issue Sep 25, 2014
@pironic
Merge pull request #6 from Reanmachine/prevent_duplicate_shoutouts
774404e 
Prevent duplicate shoutouts regardless of time thereby fixing issue #1
@pironic pironic reopened this Sep 27, 2014
@pironic
Copy link
Member Author

pironic commented Sep 27, 2014

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent duplicate shoutouts Reanmachine/GS-Broadcast-Bot
1 participant
@pironic