Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xray No longer respects fullbright #1099

Open
2 of 3 tasks
cputnam-a11y opened this issue Dec 30, 2024 · 1 comment
Open
2 of 3 tasks

Xray No longer respects fullbright #1099

cputnam-a11y opened this issue Dec 30, 2024 · 1 comment
Labels
category:render issue:could not reproduce But it works on my machine™ type:bug Something isn't working

Comments

@cputnam-a11y
Copy link

cputnam-a11y commented Dec 30, 2024

Pre-reporting checklist

  • I have searched existing issues and didn't find any previous reports of this bug.
  • This bug still happens in the latest version of Wurst. I've made sure my installation is up to date.
  • I have tried removing all other mods and the bug still happens.

Description

in past versions, using full bright with x-ray would apply fullbright to the ores, this no longer happens

Repro steps

  1. open a world
  2. enable xray
  3. enable fullbright
  4. fullbright is not applied to xrayed blocks

Wurst Client version

7.46.6

Minecraft version

1.21.4

Crash report (if applicable)

No response

@cputnam-a11y cputnam-a11y added status:unconfirmed New issue. Needs triage. type:bug Something isn't working labels Dec 30, 2024
@Alexander01998 Alexander01998 added issue:could not reproduce But it works on my machine™ category:render and removed status:unconfirmed New issue. Needs triage. labels Dec 30, 2024
@Alexander01998
Copy link
Member

Hey @cputnam-a11y,

I just tested this and it works fine for me - no dark ores when using X-Ray with Fullbright.

screenshot of X-Ray with Fullbright in Wurst 7.46.6 MC1.21.4, working correctly

Actually, the ores are always rendered at full brightness when using X-Ray, regardless of whether Fullbright is enabled or disabled. This is intentional, so that you can see them clearly even when playing without Fullbright.

Seeing dark ores with X-Ray seems like the kind of issue that would likely be caused by another mod or shader interfering with how lighting is handled. Since you mentioned you haven't tested without other mods installed yet (the pre-reporting checklist), could you try disabling your other mods one by one to figure out which one is causing this? That would help narrow down the exact cause of the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:render issue:could not reproduce But it works on my machine™ type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants