Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vte2.91: gcc10编译过会导致xfce4-terminal stack smashing detected #13

Open
RevySR opened this issue Sep 6, 2023 · 0 comments
Open

vte2.91: gcc10编译过会导致xfce4-terminal stack smashing detected #13

RevySR opened this issue Sep 6, 2023 · 0 comments

Comments

@RevySR
Copy link

RevySR commented Sep 6, 2023

更换gcc13.2 pass

前置环境配置:

https://github.com/revyos/revyos/wiki/Debian-%E8%BD%AF%E4%BB%B6%E5%8C%85%E6%9E%84%E5%BB%BA%E6%B5%81%E7%A8%8B

复现步骤：

mkdir vte2.91 && cd vte2.91
dget -d https://deb.debian.org/debian/pool/main/v/vte2.91/vte2.91_0.73.99-1.dsc

sbuild --arch=riscv64 -d sid -c sid-riscv64-revyos-c910v-sbuild vte2.91_0.73.99-1.dsc

编译完成安装 启动xfce4-terminal退出即可看到栈粉碎

Wed 2023-09-06 08:04:20 UTC  1423 1000 1000 SIGABRT present  /usr/bin/xfce4-terminal   1.2M
debian@lpi4a:~$ coredumpctl info 1423
           PID: 1423 (xfce4-terminal)
           UID: 1000 (debian)
           GID: 1000 (debian)
        Signal: 6 (ABRT)
     Timestamp: Wed 2023-09-06 08:04:19 UTC (59s ago)
  Command Line: xfce4-terminal
    Executable: /usr/bin/xfce4-terminal
 Control Group: /user.slice/user-1000.slice/session-2.scope
          Unit: session-2.scope
         Slice: user-1000.slice
       Session: 2
     Owner UID: 1000 (debian)
       Boot ID: 9a7b1d3b3e9c40e58019c40437d8b7bc
    Machine ID: d432fcb45cc9441081c722efa1c930c9
      Hostname: lpi4a
       Storage: /var/lib/systemd/coredump/core.xfce4-terminal.1000.9a7b1d3b3e9c40e58019c40437d8b7bc.1423.1693987459000000.zst (present)
  Size on Disk: 1.2M
       Message: Process 1423 (xfce4-terminal) of user 1000 dumped core.
                
                Module libsystemd.so.0 from deb systemd-252.11-1.riscv64
                Stack trace of thread 1423:
                #0  0x0000003fd13a110c __pthread_kill_implementation (libc.so.6 + 0x6d10c)
                #1  0x0000003fd136ad82 __GI_raise (libc.so.6 + 0x36d82)
                #2  0x0000003fd135a976 __GI_abort (libc.so.6 + 0x26976)
                #3  0x0000003fd1397c50 __libc_message (libc.so.6 + 0x63c50)
                #4  0x0000003fd13fd882 __GI___fortify_fail (libc.so.6 + 0xc9882)
                #5  0x0000003fd13fd850 __stack_chk_fail (libc.so.6 + 0xc9850)
                #6  0x0000003fd20ac2ba n/a (libvte-2.91.so.0 + 0x442ba)
                #7  0x0000003fd1591664 g_object_set_valist (libgobject-2.0.so.0 + 0x1c664)
                ELF object binary architecture: RISC-V

warning: Can't open file /SYSV00000000 (deleted) during file-backed mapping note processing
[New LWP 1423]
[New LWP 1425]
[New LWP 1426]
[New LWP 1424]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/riscv64-linux-gnu/libthread_db.so.1".
Core was generated by `xfce4-terminal'.
Program terminated with signal SIGABRT, Aborted.
#0  __pthread_kill_implementation (threadid=<optimized out>, signo=<optimized out>, no_tid=no_tid@entry=0) at pthread_kill.c:44
44	pthread_kill.c: No such file or directory.
[Current thread is 1 (Thread 0x3fce1e9020 (LWP 1423))]
(gdb) bt
#0  __pthread_kill_implementation (threadid=<optimized out>, signo=<optimized out>, no_tid=no_tid@entry=0) at pthread_kill.c:44
#1  0x0000003fd13a115e in __pthread_kill_internal (signo=<optimized out>, threadid=<optimized out>) at pthread_kill.c:78
#2  0x0000003fd136ad82 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#3  0x0000003fd135a976 in __GI_abort () at abort.c:79
#4  0x0000003fd1397c50 in __libc_message (action=action@entry=do_abort, fmt=fmt@entry=0x3fd1450b30 "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:155
#5  0x0000003fd13fd882 in __GI___fortify_fail (msg=msg@entry=0x3fd1450b18 "stack smashing detected") at fortify_fail.c:26
#6  0x0000003fd13fd850 in __stack_chk_fail () at stack_chk_fail.c:24
#7  0x0000003fd20ac2ba in vte_terminal_set_property (object=0x2ac22ee3a0, prop_id=<optimized out>, value=<optimized out>, pspec=0x2ac25c1460) at ../src/vtegtk.cc:1166
#8  0x0000003fd1591664 in object_set_property (user_specified=1, nqueue=<optimized out>, value=0x3fffc94a20, pspec=0x2ac25c1460, object=0x2ac22ee3a0) at ../../../gobject/gobject.c:1821
#9  g_object_set_valist (object=0x2ac22ee3a0, first_property_name=<optimized out>, var_args=0x3fffc94b28) at ../../../gobject/gobject.c:2763
#10 0x0000003fd1591e70 in g_object_set (_object=_object@entry=0x2ac22ee3a0, first_property_name=first_property_name@entry=0x3fd1d94c58 "hadjustment") at ../../../gobject/gobject.c:2939
#11 0x0000003fd1bd474a in gtk_scrolled_window_remove (container=0x2ac26323d0, child=child@entry=0x2ac22ee3a0) at ../../../gtk/gtkscrolledwindow.c:4118
#12 0x0000003fd158cbd6 in g_cclosure_marshal_VOID__OBJECTv (closure=0x2ac2342e30, return_value=<optimized out>, instance=0x2ac26323d0, args=<optimized out>, 
    marshal_data=0x3fd1bd46f0 <gtk_scrolled_window_remove>, n_params=<optimized out>, param_types=<optimized out>) at ../../../gobject/gmarshal.c:1910
#13 0x0000003fd158a90c in _g_closure_invoke_va (closure=0x2ac2342e30, return_value=0x0, instance=0x2ac26323d0, args=0x3fffc94dd8, n_params=<optimized out>, param_types=0x2ac2342e60)
    at ../../../gobject/gclosure.c:895
#14 0x0000003fd15a33e6 in g_signal_emit_valist (instance=instance@entry=0x2ac26323d0, signal_id=115, detail=<optimized out>, var_args=var_args@entry=0x3fffc94dd8)
    at ../../../gobject/gsignal.c:3456
#15 0x0000003fd15a36ba in g_signal_emit (instance=instance@entry=0x2ac26323d0, signal_id=<optimized out>, detail=detail@entry=0) at ../../../gobject/gsignal.c:3606
#16 0x0000003fd1a78526 in gtk_container_remove (container=0x2ac26323d0, widget=0x2ac22ee3a0) at ../../../gtk/gtkcontainer.c:1907
#17 0x0000003fd1c9a936 in gtk_widget_dispose (object=0x2ac22ee3a0) at ../../../gtk/gtkwidget.c:12155
#18 0x0000003fd20a1f66 in vte_terminal_dispose (object=0x2ac22ee3a0) at ../src/vtegtk.cc:891
#19 0x0000003fd158fc70 in g_object_run_dispose (object=0x2ac22ee3a0) at ../../../gobject/gobject.c:1448
#20 0x0000003fd1c913e8 in gtk_widget_destroy (widget=<optimized out>) at ../../../gtk/gtkwidget.c:4780
#21 0x0000003fd1bd5678 in gtk_scrolled_window_destroy (widget=0x2ac26323d0) at ../../../gtk/gtkscrolledwindow.c:2821
#22 0x0000003fd158a6b6 in g_closure_invoke (closure=0x2ac22f2f80, return_value=0x0, n_param_values=<optimized out>, param_values=0x3fffc950c0, invocation_hint=0x3fffc95018)
    at ../../../gobject/gclosure.c:832
#23 0x0000003fd159a82a in signal_emit_unlocked_R (node=node@entry=0x2ac232fb20, detail=detail@entry=0, instance=instance@entry=0x2ac26323d0, emission_return=emission_return@entry=0x0, 
    instance_and_params=instance_and_params@entry=0x3fffc950c0) at ../../../gobject/gsignal.c:3914
#24 0x0000003fd15a33fa in g_signal_emit_valist (instance=instance@entry=0x2ac26323d0, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x3fffc95288)
    at ../../../gobject/gsignal.c:3549
#25 0x0000003fd15a36ba in g_signal_emit (instance=instance@entry=0x2ac26323d0, signal_id=<optimized out>, detail=detail@entry=0) at ../../../gobject/gsignal.c:3606
#26 0x0000003fd1c9aa04 in gtk_widget_dispose (object=0x2ac26323d0) at ../../../gtk/gtkwidget.c:12166
#27 0x0000003fd158fc70 in g_object_run_dispose (object=0x2ac26323d0) at ../../../gobject/gobject.c:1448
#28 0x0000003fd1b7ddf8 in gtk_overlay_forall (overlay=0x2ac23083a0, include_internals=<optimized out>, callback=0x3fd1c91390 <gtk_widget_destroy>, callback_data=0x0)
    at ../../../gtk/gtkoverlay.c:628
#29 0x0000003fd1a7a066 in gtk_container_destroy (widget=0x2ac23083a0) at ../../../gtk/gtkcontainer.c:1702
#30 0x0000003fd158a6b6 in g_closure_invoke (closure=0x2ac22f2f80, return_value=0x0, n_param_values=<optimized out>, param_values=0x3fffc95530, invocation_hint=0x3fffc95488)
    at ../../../gobject/gclosure.c:832
#31 0x0000003fd159a82a in signal_emit_unlocked_R (node=node@entry=0x2ac232fb20, detail=detail@entry=0, instance=instance@entry=0x2ac23083a0, emission_return=emission_return@entry=0x0, 
    instance_and_params=instance_and_params@entry=0x3fffc95530) at ../../../gobject/gsignal.c:3914
#32 0x0000003fd15a33fa in g_signal_emit_valist (instance=instance@entry=0x2ac23083a0, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x3fffc956f8)
    at ../../../gobject/gsignal.c:3549
#33 0x0000003fd15a36ba in g_signal_emit (instance=instance@entry=0x2ac23083a0, signal_id=<optimized out>, detail=detail@entry=0) at ../../../gobject/gsignal.c:3606
#34 0x0000003fd1c9aa04 in gtk_widget_dispose (object=0x2ac23083a0) at ../../../gtk/gtkwidget.c:12166
#35 0x0000003fd158fc70 in g_object_run_dispose (object=0x2ac23083a0) at ../../../gobject/gobject.c:1448
#36 0x0000003fd1b7662c in gtk_notebook_forall (container=<optimized out>, include_internals=<optimized out>, callback=0x3fd1c91390 <gtk_widget_destroy>, callback_data=0x0)
    at ../../../gtk/gtknotebook.c:4608
--Type <RET> for more, q to quit, c to continue without paging--
#37 0x0000003fd1a7a066 in gtk_container_destroy (widget=0x2ac25c2240) at ../../../gtk/gtkcontainer.c:1702
#38 0x0000003fd158a6b6 in g_closure_invoke (closure=0x2ac22f2f80, return_value=0x0, n_param_values=<optimized out>, param_values=0x3fffc959b0, invocation_hint=0x3fffc95908)
    at ../../../gobject/gclosure.c:832
#39 0x0000003fd159a82a in signal_emit_unlocked_R (node=node@entry=0x2ac232fb20, detail=detail@entry=0, instance=instance@entry=0x2ac25c2240, emission_return=emission_return@entry=0x0, 
    instance_and_params=instance_and_params@entry=0x3fffc959b0) at ../../../gobject/gsignal.c:3914
#40 0x0000003fd15a33fa in g_signal_emit_valist (instance=instance@entry=0x2ac25c2240, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x3fffc95b78)
    at ../../../gobject/gsignal.c:3549
#41 0x0000003fd15a36ba in g_signal_emit (instance=instance@entry=0x2ac25c2240, signal_id=<optimized out>, detail=detail@entry=0) at ../../../gobject/gsignal.c:3606
#42 0x0000003fd1c9aa04 in gtk_widget_dispose (object=0x2ac25c2240) at ../../../gtk/gtkwidget.c:12166
#43 0x0000003fd158fc70 in g_object_run_dispose (object=0x2ac25c2240) at ../../../gobject/gobject.c:1448
#44 0x0000003fd1a335b0 in gtk_box_forall (container=<optimized out>, include_internals=<optimized out>, callback=0x3fd1c91390 <gtk_widget_destroy>, callback_data=0x0)
    at ../../../gtk/gtkbox.c:2678
#45 0x0000003fd1a7a066 in gtk_container_destroy (widget=0x2ac25b9f40) at ../../../gtk/gtkcontainer.c:1702
#46 0x0000003fd158a6b6 in g_closure_invoke (closure=0x2ac22f2f80, return_value=0x0, n_param_values=<optimized out>, param_values=0x3fffc95e20, invocation_hint=0x3fffc95d78)
    at ../../../gobject/gclosure.c:832
#47 0x0000003fd159a82a in signal_emit_unlocked_R (node=node@entry=0x2ac232fb20, detail=detail@entry=0, instance=instance@entry=0x2ac25b9f40, emission_return=emission_return@entry=0x0, 
    instance_and_params=instance_and_params@entry=0x3fffc95e20) at ../../../gobject/gsignal.c:3914
#48 0x0000003fd15a33fa in g_signal_emit_valist (instance=instance@entry=0x2ac25b9f40, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x3fffc95fe8)
    at ../../../gobject/gsignal.c:3549
#49 0x0000003fd15a36ba in g_signal_emit (instance=instance@entry=0x2ac25b9f40, signal_id=<optimized out>, detail=detail@entry=0) at ../../../gobject/gsignal.c:3606
#50 0x0000003fd1c9aa04 in gtk_widget_dispose (object=0x2ac25b9f40) at ../../../gtk/gtkwidget.c:12166
#51 0x0000003fd158fc70 in g_object_run_dispose (object=0x2ac25b9f40) at ../../../gobject/gobject.c:1448
#52 0x0000003fd1cab4a6 in gtk_window_forall (container=0x2ac25a0350, include_internals=<optimized out>, callback=0x3fd1c91390 <gtk_widget_destroy>, callback_data=0x0)
    at ../../../gtk/gtkwindow.c:8632
#53 0x0000003fd1a7a066 in gtk_container_destroy (widget=0x2ac25a0350) at ../../../gtk/gtkcontainer.c:1702
#54 0x0000003fd158a75e in g_closure_invoke (closure=0x2ac22f2f80, return_value=0x0, n_param_values=<optimized out>, param_values=0x3fffc962a0, invocation_hint=0x3fffc961f8)
    at ../../../gobject/gclosure.c:832
#55 0x0000003fd159a82a in signal_emit_unlocked_R (node=node@entry=0x2ac232fb20, detail=detail@entry=0, instance=instance@entry=0x2ac25a0350, emission_return=emission_return@entry=0x0, 
    instance_and_params=instance_and_params@entry=0x3fffc962a0) at ../../../gobject/gsignal.c:3914
#56 0x0000003fd15a33fa in g_signal_emit_valist (instance=instance@entry=0x2ac25a0350, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x3fffc96468)
    at ../../../gobject/gsignal.c:3549
#57 0x0000003fd15a36ba in g_signal_emit (instance=instance@entry=0x2ac25a0350, signal_id=<optimized out>, detail=detail@entry=0) at ../../../gobject/gsignal.c:3606
#58 0x0000003fd1c9aa04 in gtk_widget_dispose (object=0x2ac25a0350) at ../../../gtk/gtkwidget.c:12166
#59 0x0000003fd1cae1ae in gtk_window_dispose (object=0x2ac25a0350) at ../../../gtk/gtkwindow.c:3191
#60 0x0000003fd158fc70 in g_object_run_dispose (object=0x2ac25a0350) at ../../../gobject/gobject.c:1448
#61 0x0000003fd1c913e8 in gtk_widget_destroy (widget=<optimized out>) at ../../../gtk/gtkwidget.c:4780
#62 0x0000003fd1b4c0d4 in gtk_main_do_event (event=0x2ac2718210) at ../../../gtk/gtkmain.c:1837
#63 gtk_main_do_event (event=<optimized out>) at ../../../gtk/gtkmain.c:1691
#64 0x0000003fd18d82c0 in _gdk_event_emit (event=event@entry=0x2ac2718210) at ../../../gdk/gdkevents.c:73
#65 0x0000003fd1925d5a in gdk_event_source_dispatch (source=<optimized out>, callback=<optimized out>, user_data=<optimized out>) at ../../../gdk/x11/gdkeventsource.c:367
#66 0x0000003fd14bf060 in g_main_dispatch (context=0x2ac22e9940) at ../../../glib/gmain.c:3454
#67 g_main_context_dispatch (context=context@entry=0x2ac22e9940) at ../../../glib/gmain.c:4172
#68 0x0000003fd14bf21a in g_main_context_iterate (context=0x2ac22e9940, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../../../glib/gmain.c:4248
#69 0x0000003fd14bf4a0 in g_main_loop_run (loop=0x2ac22bfb30) at ../../../glib/gmain.c:4448
#70 0x0000003fd1b4b032 in gtk_main () at ../../../gtk/gtkmain.c:1329
#71 0x0000002ac225e060 in main ()
Backtrace stopped: frame did not save the PC
RevySR pushed a commit to revyos/gcc that referenced this issue Jan 1, 2025
@kito-cheng
RISC-V: Fix vsetvli local eliminate [PR114747]
c4c0b0b 
vsetvli local eliminate is only consider the current demand instead of
full demand, and it will use that incomplete info to remove vsetvli.

Give following example from PR114747:

vsetvli a5,a1,e8,m4,ta,mu       # 57, ratio=2, sew=8, lmul=4
vsetvli zero,a5,e16,m8,ta,ma    # 58, ratio=2, sew=16, lmul=8
vle8.v  v8,0(a0)        # 13, demand ratio=2
vzext.vf2       v24,v8  # 14, demand sew=16 and lmul=8

Insn gcc-mirror#58 will removed because gcc-mirror#57 has satisfied demand of XUANTIE-RV#13, but it's
not consider XUANTIE-RV#14.

It should doing more demand analyze, but this bug only present in GCC 13
branch, and we should not change too much on this release branch, so the best
way is make the check more conservative - remove only if the target
vsetvl_discard_result having same SEW and LMUL as the source vsetvli.

gcc/ChangeLog:

	PR target/114747
	* config/riscv/riscv-vsetvl.cc (local_eliminate_vsetvl_insn):
	Check target vsetvl_discard_result and source vsetvli has same
	SEW and LMUL.

gcc/testsuite/ChangeLog:

	* gcc.target/riscv/rvv/vsetvl/pr114747.c: New.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RevySR