Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library cannot be loaded via composer #3

Open
oadam opened this issue Oct 16, 2015 · 6 comments
Open

Library cannot be loaded via composer #3

oadam opened this issue Oct 16, 2015 · 6 comments

Comments

@oadam
Copy link

oadam commented Oct 16, 2015

When I decided to use this library, I added it to my composer.json file and expected it to work out of the box.
After painful hours of debugging, I re-read the README file and came to realise that the only way to install this library is to git clone it and run composer from within the cloned folder.

  • Ideally it would be great if the library could be installed via composer.
  • If not possible, could you at least add a bold statement at the start of the README saying that installation via composer is not supported ?

Thanks,
Olivier

@lsolesen
Copy link
Contributor

You can find it on packagist here: https://packagist.org/packages/yotpo/yotpo

@oadam
Copy link
Author

oadam commented Mar 24, 2016

It is on packagist but the package doesn't work if installed with composer.
Last time I checked, Yotpo assumed its folder contained a vendor folder.
The only way I managed to make it work was to download the directory from github, cd to it, and run composer install

@lsolesen
Copy link
Contributor

Ah. Ok. I will try it out.

@lsolesen
Copy link
Contributor

Hi @oadam I've created a pull request, which should fix this: #5. Do you care to take it for a spin to see whether you like how it turned out. Then hopefully @vladshub will merge it in and tag a new version (which should probably be 0.0.3 which is not released yet https://github.com/YotpoLtd/yotpo-php/blob/master/src/Yotpo/Yotpo.php#L16)

@oadam
Copy link
Author

oadam commented Mar 24, 2016

I should be able to have a look at this tomorrow. Thanks !

@mattmintun
Copy link

3 years later - I'm here to say that @lsolesen edits make this repository actually work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants