Add support for communication via NFC for Windows

[kmenshikh]

Inspired from: #249 (Add support for communication via NFC for MacOS #249)

Is it possible to do subj?
I've tried to do this (via Windows SmartCard API) and it works good on Windows 10 (on Windows 7 there are troubles).
"I've tried" means i extended functionality of libfido2.

It seems it's not hard enough.

[martelletto]

Hi, sure, that'd be a nice addition. Could you share some code?

[kmenshikh]

I need to get approval from my managers to share code.
Once i get it i'll post code here.

[kmenshikh]

JFI: I don't forget about "share some code".
Approval process is in progress (big company - big bureaucracy).

[brett-berger]

@martelletto does Yubikey have a Contributors License agreement (CLA) you can point me to? Before @kmenshikh can share his code our legal team wants to review Yubikey's CLA. thx

[martelletto]

@brett-berger, as long as the contributed code is under the same license as libfido2, we typically don't require a CLA: https://github.com/Yubico/libfido2/blob/master/LICENSE. Should that prove unsatisfactory to your legal team, could you please reach out to me at pedro [at] yubico [dot] com? Thank you.

[kmenshikh]

Hi, @martelletto

I finally got approval.
See nfc_win_patch.txt
nfc_win.zip

Some notices:

(1) Provided code is based on the libfido2 v1.8.0 release.
So some modification may be required to comply current code base.

(2) libfido2 always use extended apdu format.
But some cards (HID Crescendo C2300 CL, for example) respect only "short apdu" for "select" command.
That's why for this command short format used. (YubiKey 5 NFC respects both formats).

(3) I didn't test scenario when both (WINHELLO and WIN_NFC) features are enabled.

[martelletto]

Thank you! For uniformity with the rest of the files in src/, would it be possible for the copyright notice to read:

/*                                                                              
 * Copyright (c) 2022 Micro Focus PLC or one of its affiliates.                 
 * Use of this source code is governed by a BSD-style license                   
 * that can be found in the LICENSE file.                                       
 */ 

or, if that's not acceptable, to include the entire license text in the copyright notice, so that it's all in one place?

-p.

[kmenshikh]

@brett-berger could you answer @martelletto 's question?

[brett-berger]

@martelletto this works for us.

/*

• © Copyright 2022 Micro Focus or one of its affiliates.
• Use of this source code is governed by a BSD-style license
• that can be found in the LICENSE file.
  */