Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't select service road #84

Open
NeatNit opened this issue Oct 17, 2024 · 8 comments
Open

Can't select service road #84

NeatNit opened this issue Oct 17, 2024 · 8 comments

Comments

@NeatNit
Copy link

NeatNit commented Oct 17, 2024

I tried to edit this relation: https://relatify.monicz.dev/?relation=15865883&load=1#map=19/32.793268/34.958660

The first few ways in the relation are apparently marked highway=service + service=bus. When loaded into realtify, these ways are removed and impossible to select.

I thought it might be because of access=no but I added bus=designated to the roads and it still wouldn't load. I figured before I mess around more I should ask - how is this supposed to work?

Also, I think it's very alarming that Realtify silently removes roads that are already in the relation. It shouldn't remove data, certainly not silently.

Edit: although let me say, this is my first time using Realtify and despite this experience it looks like an amazing tool! Well done!

@Zaczero
Copy link
Owner

Zaczero commented Oct 17, 2024

Is service=bus a proper tagging? First time hearing of it (I'm on mobile and can't check myself). 😜

@NeatNit
Copy link
Author

NeatNit commented Oct 17, 2024

I have no idea, probably not, but that's how it was tagged. Do you operate on a whitelist? I expected a blacklist based on your reply in #2.

Edit: the wiki allows user-defined values for service=*: https://wiki.openstreetmap.org/wiki/Key:service#Highways

@mutipg
Copy link

mutipg commented Oct 17, 2024

I don't see a problem in 'Relatify' with the first ways of the bus route.

After adding the bus=designated tag, did you wait a few minutes for the data to propagate in the OSM database?

image

@Zaczero
Copy link
Owner

Zaczero commented Oct 17, 2024

Now that I'm at my desktop, I can confirm that this tagging shouldn't be causing problems:

osm-relatify/overpass.py

Lines 169 to 174 in 91d26e5

service_valid = tags.get('service', 'no') not in {
'driveway',
'parking_aisle',
'alley',
'emergency_access',
}

Only 4 values are explicitly blacklisted 🙂.

As @mutipg said: it's possible this was a data synchronization delay issue (Relatify uses Overpass to fetch data).

@NeatNit
Copy link
Author

NeatNit commented Oct 17, 2024

After adding the bus=designated tag, did you wait a few minutes for the data to propagate in the OSM database?

This might have been it. Whoops! Seems like that is working correctly.

But still, I want to reiterate this:

Also, I think it's very alarming that Realtify silently removes roads that are already in the relation. It shouldn't remove data, certainly not silently.

@Zaczero
Copy link
Owner

Zaczero commented Oct 18, 2024

There is a validation system in Relatify that will notify you if the relation seems weird: if stops are not reached, if path is not continuous (missing ways), if stops are far away from the road, and a few others..

I haven't seen this being an issue 😊👍

@RobinLinde
Copy link

I don't exactly know how this works out worldwide, but in my local area there's quite some bus lines that actually use parking aisles in their route, mostly to get closer to shopping centres or to turn around. Seems mostly a thing for buurtbus (really can't find a translation) lines.
Thus, when starting to edit those I usually see problems like this:
screenshot showing missing ways

@mutipg
Copy link

mutipg commented Dec 30, 2024

If your bus route is using highway=service + service=* ways than you have to add extra tag bus=yes to them - in your example @RobinLinde you have to update this way with bus=yes tag. Wait 3 minutes and this way will be selectable in Relatify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants