Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling and general UX in Node Configuration #2172

Open
myxmaster opened this issue May 2, 2024 · 0 comments · May be fixed by #2594
Open

Better error handling and general UX in Node Configuration #2172

myxmaster opened this issue May 2, 2024 · 0 comments · May be fixed by #2594

Comments

@myxmaster
Copy link
Contributor

myxmaster commented May 2, 2024

Describe your enhancement idea

General:
Error and success messages should be reset when leaving the screen (right now e.g. click "CREATE LNDHUB ACCOUNT" with empty Host, leave the view and come back -> you will still see the error).

LNDHub:

  1. Disable "CREATE LNDHUB ACCOUNT" button if Host is empty. In case user is setting up an existing account: Disable button if Host or Username or Password is empty.
  2. Host input typing: block all illegal hostname-chars
  3. Host input pasting: auto clean leading/trailing white spaces and line breaks, display error message if illegal chars within data were pasted
  4. Existing Account->Username input typing: block space chars
  5. Existing Account->Username input pasting: auto clean leading/trailing white spaces and line breaks, display error message if space char within data was pasted
  6. Existing Account -> Password input: no blocking of space chars, no autoCorrect

LND (Lightning Node Connect):

  1. Pairing Phrase input typing: block all chars but a-z, A-Z and space char (also block space char if it is the first char in the input, also block space char if it is more than 1 space char in a row)
  2. Pairing Phrase input pasting: auto clean leading/trailing white spaces and line breaks, also auto-replace more than 1 space char in a row into 1, also auto-clean line breaks in between words, display error message if illegal chars pasted
  3. Pairing Phrase input focus loss: display error message if pairing phrase is not exactly 10 words, no error message if pairing phrase is empty -> user obviously wants to do other stuff first
  4. Custom Mailbox Server input typing: block all illegal hostname-chars (but allow :)
  5. Custom Mailbox Server input pasting: auto clean leading/trailing white spaces and line breaks, display error message if illegal chars pasted
  6. Custom Mailbox Server input focus loss: display error message if not formatted host:port or host (default port 443 ist used in this case), no error message if custom mailbox server is empty -> user obviously wants to do other stuff first
  7. Disable "SAVE NODE CONFIG" button if Pairing Phrase word count is != 10 (or if Custom Mailbox Server is used, but it's not formatted host:port or host).

LND (Rest) / Core Lightning (CLNRest) / Core Lightning (c-lightning-REST):

  1. Host input typing: block all illegal hostname-chars
  2. Host input pasting: auto clean leading/trailing white spaces and line breaks, display error message if illegal chars within data were pasted
  3. LND/c-Lightning-REST: Macaroon input typing: block non-hex chars (although it shouldnt really happen that users type a macaroon)
  4. LND/c-Lightning-REST: Macaroon input pasting: auto clean leading/trailing white spaces and line breaks, display error message if illegal chars within data were pasted
  5. CLNRest: Rune input typing: block illegal chars (although it shouldnt really happen that users type a rune)
  6. CLNRest: Rune input pasting: auto clean leading/trailing white spaces and line breaks, display error message if illegal chars within data were pasted
  7. Disable "SAVE NODE CONFIG" button if Host or Macaroon/Rune is empty (empty REST Port is ok, since Zeus will try default port)

We should improve error handling, when you enter a well formatted but invalid Macaroon, right now you get this:
grafik

@myxmaster myxmaster changed the title Better error handling in Node Configuration Better error handling and general UI in Node Configuration Dec 2, 2024
@myxmaster myxmaster changed the title Better error handling and general UI in Node Configuration Better error handling and general UX in Node Configuration Dec 2, 2024
@myxmaster myxmaster linked a pull request Dec 2, 2024 that will close this issue
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants