Skip to content

You should not call this method directly for Google, use "<asl-google-signin-button>" #596

Answered by nwalkewicz
DylanPrimera asked this question in Q&A
Discussion options

You must be logged in to vote

I'm not sure why, but the documentation for this project doesn't match what the code says (as of 4bd9414). In order to create a Google Sign-in button, you have to use the directive <asl-google-signin-button> rather than calling the authService.signIn() method. As far as I know, every other method still works fine.

To see what the example uses, look at the template and removal of signInWithGoogle() method.

Edit:

It seems the GitHub documentation is updated with the newer way to use the Google Sign-in button, but the NPM docs aren't. See Sign in with google for details on how to implement it.

Replies: 3 comments 7 replies

Comment options

You must be logged in to vote
6 replies
@nwalkewicz
Comment options

@brandondunc94
Comment options

@nwalkewicz
Comment options

@DylanPrimera
Comment options

@brandondunc94
Comment options

Answer selected by DylanPrimera
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
1 reply
@nwalkewicz
Comment options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
4 participants